refactor(CatalogHelpers): remove catalog diff helper methods #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @pedroslopez and the rest of your teammates on |
pedroslopez
changed the title
pedroslopez
changed the title
pedroslopez
changed the title
evantahler
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This removes a group of methods that deal with comparing catalogs and returning the diff. These methods are a platform concern, and it makes it hard to iterate on the diffing logic / what we consider transforms and breaking changes.
These helpers are not part of the protocol itself, but rather helpers. As such, we've moved the diff-related methods into the platform in https://github.com/airbytehq/airbyte-platform-internal/pull/12303
I've only pulled out the methods needed for diffing instead of removing the whole CatalogHelpers class because the connectors repo relies on some of these helpers in the tests (to ie create a configured catalog or get top-level fields). I've looked through the airbyte connector codebase and none of the removed methods on this PR are used by it.