feat: new dataclasses version of python protocol, temporarily alongside pydantic version #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @erohmensing and the rest of your teammates on |
erohmensing
force-pushed
the
ella/dataclases
branch
from
4e388dc to
c698f3e
Compare
erohmensing
changed the title
erohmensing
force-pushed
the
ella/dataclases
branch
from
9cff5a0 to
5f57711
Compare
natikgadzhi
approved these changes
Jun 10, 2024
| docker run --rm \ | ||
| --volume "${ROOT_DIR}:/${ROOT_DIR_NAME}" \ | ||
| --workdir "/${ROOT_DIR_NAME}" \ | ||
| python:3.8 "/${ROOT_DIR_NAME}/protocol-models/bin/generate-python-dataclasses.sh" |
There was a problem hiding this comment.
Should we use 3.10 here? Not sure if that would change anything at all.
| @@ -0,0 +1,19 @@ | |||
| Copyright (c) 2020 Airbyte | |||
There was a problem hiding this comment.
Suggested change
| Copyright (c) 2020 Airbyte | |
| Copyright (c) 2024 Airbyte |
| "License :: OSI Approved :: MIT License", | ||
| # Python Version Support | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.8", |
There was a problem hiding this comment.
Nit: We could add more python versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Generate a second version of the python protocol, by generating dataclasses instead of pydantic models. Publish this class to
airbyte_protocol_models_dc, a temporary package.How
Publish 2 packages side by side for now. This gives us the ability to see how things go in production without doing a hard cutover, and migrate pieces off of the pydantic version incrementally (the CDK first).
We are still using
datamodel-codegento create the models from jsonschema, but we use a different output type and an updated version of the library for generation.