Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update source-declarative-manifest entrypoint #84

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

ChristoGrab
Copy link
Collaborator

@ChristoGrab ChristoGrab commented Nov 22, 2024

Description

Follow up to #83

The platform's orchestrator has specific requirements about how it executes connector containers. Our entrypoint using poetry run was causing failures in both Cloud and OSS environments. This change aligns our container configuration with platform expectations.

Changes

  • Removes poetry run from the entrypoint command
  • Adds AIRBYTE_ENTRYPOINT environment variable required by the platform

How to test

  1. Build and publish a dev version of the SDM image
  2. Create a custom connector in Cloud using the new image version
  3. Verify the connector can run through the platform

Summary by CodeRabbit

  • New Features
    • Introduced an environment variable AIRBYTE_ENTRYPOINT to streamline the entrypoint command.
  • Bug Fixes
    • Simplified the entrypoint configuration for improved execution of the source-declarative-manifest.

@github-actions github-actions bot added bug Something isn't working security labels Nov 22, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review November 22, 2024 19:11
Copy link
Contributor

coderabbitai bot commented Nov 22, 2024

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request focus on the Dockerfile, specifically updating the entrypoint configuration. The previous entrypoint command using Poetry has been simplified to directly invoke source-declarative-manifest. An environment variable, AIRBYTE_ENTRYPOINT, has been added to store the entrypoint command. The dependency installation process remains unchanged, and the overall structure of the Dockerfile is preserved.

Changes

File Change Summary
Dockerfile - Added environment variable: ENV AIRBYTE_ENTRYPOINT="source-declarative-manifest"
- Updated entrypoint from ENTRYPOINT ["poetry", "run", "source-declarative-manifest"] to ENTRYPOINT ["source-declarative-manifest"]

Possibly related PRs

Suggested labels

ci

Suggested reviewers

  • aaronsteers
  • natikgadzhi
  • maxi297

Wdyt about these suggestions?


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ChristoGrab ChristoGrab enabled auto-merge (squash) November 22, 2024 19:55
@aaronsteers aaronsteers merged commit a8b1b2b into main Nov 22, 2024
22 of 23 checks passed
@aaronsteers aaronsteers deleted the christo/sdm-entrypoint branch November 22, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants