chore: make SDM image rootless #147
Conversation
This reverts commit 59505ff.
alafanechere
force-pushed
the
augustin/sdm-rootless
branch
from
1442b1a to
48bfb51
Compare
alafanechere
temporarily deployed
to
DockerHub
GitHub Actions
Inactive
📝 Walkthrough📝 WalkthroughWalkthroughThe Dockerfile has been updated to use a newer base image, transitioning from Changes
Possibly related PRs
Suggested reviewers
Wdyt about reaching out to these reviewers for their insights? 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Dockerfile (1)
26-28: Great security improvements! 🛡️ A couple of suggestions...Love the rootless container setup! Would you consider these additional improvements? wdyt?
- Using numeric UID for better compatibility across platforms:
-RUN chown -R airbyte /airbyte +RUN chown -R 1000:1000 /airbyte -USER airbyte +USER 1000
- Moving WORKDIR after USER to ensure all directory accesses are non-root:
RUN chown -R airbyte /airbyte +USER airbyte +WORKDIR /airbyte/integration_code ENV AIRBYTE_ENTRYPOINT="python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -USER airbyteAlso applies to: 32-32
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
Dockerfile(2 hunks)
🔇 Additional comments (2)
Dockerfile (2)
Line range hint 1-32: Overall implementation looks solid! 🚀
The changes effectively achieve the goal of making the SDM image rootless while maintaining proper security practices. Nice work on implementing this security improvement!
1-1: Verify compatibility with base image v3.0.0
The major version bump from 2.0.0 to 3.0.0 could introduce breaking changes. Great job including the SHA256 digest for immutability! 🔒
Let's check the changelog and any breaking changes:
|
@ChristoGrab published a pre-release of the image and successfully tested |
There was a problem hiding this comment.
Looks good! And grateful to you both (@alafanechere and @ChristoGrab) for the extra step of manually pre-testing in Cloud.
One inline comment for clarification and I think this is ready to go! 🚀
|
@alafanechere and @ChristoGrab - Will one of you be able to monitor after deploying? Specifically:
(This would be helpful to add to our |
|
Also (fyi) after this merges, we can release in the normal way - by publishing the draft release (https://github.com/airbytehq/airbyte-python-cdk/releases). It should automatically rebuild and republish with this Dockerfile definition. 🚀 |
There was a problem hiding this comment.
Sounds like manual testing is not 100% green as of now.
Requesting pause on auto-merge until we are sure (especially ahead of the weekend).
cc @alafanechere and @ChristoGrab
|
@alafanechere - I don't remember us overriding how the image is built during Can you confirm if that is your understanding as well? |
alafanechere
temporarily deployed
to
DockerHub
GitHub Actions
Inactive
@aaronsteers your understanding is correct. The automated connector testing on CDK change in this repo does not use the "dev" image. Which image is used by a connector is defined in its metadata.yaml which we're not editing at test time via |
Summary by CodeRabbit
New Features
Bug Fixes