ci: update connector-tests.yml worfklow to use dev binary of airbyte-ci

[alafanechere]

This pull request includes changes to the .github/workflows/connector-tests.yml file to re-enable manfiest only connectors and update the way the Airbyte CI is run for connector tests. The most important changes include re-enabling the source-the-guardian-api and source-pokeapi connectors, and switching to a custom GitHub action for running Airbyte CI.

Connector re-enablement:

• Re-enabled the source-the-guardian-api and source-pokeapi connectors by removing previous comments that disabled them.

CI process update:

• Updated the connector test job to use a custom GitHub action (run-airbyte-ci) instead of running the Airbyte CI commands directly within the workflow.
• Added a context input with the value pull_request and a subcommand input to specify the test command for the connector.
• Included a temporary airbyte_ci_binary_url to use a custom binary URL for the Airbyte CI version of the pull request.

Summary by CodeRabbit

• New Features

  • Added support for testing two new connectors: source-the-guardian-api and source-pokeapi.

• Improvements

  • Updated the testing workflow to enhance connector testing processes.
  • Renamed the Test Connector step for clarity and added an identifier for better tracking.

• Bug Fixes

  • Removed outdated comments that previously excluded certain connectors from testing.

• Chores

  • Updated project configuration for build system and dependencies in pyproject.toml.
  • Introduced a new section for enhanced project management and future improvements.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request modifies the .github/workflows/connector-tests.yml workflow file to include two new connectors, source-the-guardian-api and source-pokeapi, in the connectors_ci job's matrix configuration. It also updates the naming and execution of the Test connector step, which now uses a custom action for testing. The previous environment variables have been removed, but the output evaluation logic remains unchanged. These changes signify an update in the testing approach for the connectors.

Changes

File Path	Change Summary
.github/workflows/connector-tests.yml	- Added connectors: source-the-guardian-api, source-pokeapi to connectors_ci job. - Renamed step from Test Connector to Test connector and added id: run-airbyte-ci-connector-test-pr. - Modified execution to use custom action at ./airbyte/.github/actions/run-airbyte-ci. - Removed previous environment variables from the step. - Retained output evaluation step logic and job output artifact upload.

Possibly related PRs

• Feat: Incorporate SDM in CDK and add publish workflow #58: This PR adds the same connectors, source-the-guardian-api and source-pokeapi, to the connectors_ci job's matrix configuration in the .github/workflows/connector-tests.yml, directly relating to the changes made in the main PR.
• ci: replace faker with hardcoded source #42: This PR updates the connectors_ci job in the same workflow file by adding a new connector, source-hardcoded-records, which indicates ongoing modifications to the connector testing process.
• ci: run airbyte connector tests from master branch #99: This PR modifies the connectors_ci job in the same workflow file, focusing on the management of connector definitions and their testing, which is relevant to the changes in the main PR.
• ci: skip downstream connector tests if no source code is changed #101: This PR enhances the logic for determining when to abort jobs in the connectors_ci job, which is related to the overall testing strategy in the main PR.
• ci: fix CI reports not uploading #138: This PR improves the reporting capabilities of the connectors_ci job, which aligns with the changes in the main PR that also focuses on enhancing the testing workflow.

Suggested labels

enhancement

Suggested reviewers

• aaronsteers
• ChristoGrab
• erohmensing

What do you think about these suggestions? wdyt?

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9e45294 and ff964fa.

📒 Files selected for processing (2)

• .github/workflows/connector-tests.yml (1 hunks)
• pyproject.toml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• pyproject.toml

🔇 Additional comments (2)

.github/workflows/connector-tests.yml (2)

91-94: LGTM! Matrix configuration looks good! 🎉

The addition of source-the-guardian-api and source-pokeapi follows the same pattern as other connectors in the matrix. Both are correctly configured with cdk_extra: n/a.

---

Line range hint 155-167: Should we track the TODO with an issue? 🤔

The switch to airbyte-ci-dev is marked as temporary with a TODO. Would it be helpful to create a tracking issue for reverting back to tools.airbyte-ci-binary.install after the Airbyte CI release? This could help ensure we don't forget to make the switch back.

Also, just to verify - are we intentionally skipping both qa_checks and connector_live_tests steps? wdyt?

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

.github/workflows/connector-tests.yml (1)

130-132: Consider documenting the temporary binary URL situation.

The TODO comment indicates this is a temporary solution. Would it be helpful to add a link to the related issue or PR (#48818) in the comment for better context? Also, what's the timeline for removing this temporary solution, wdyt?

pyproject.toml (1)

204-205: Clarify the TODO comment.

The comment "TODO revert me" lacks context. Could you provide more details about what needs to be reverted and under what conditions? This will help future maintainers understand the temporary nature of whatever change this refers to.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7ce9c36 and 956fe71.

📒 Files selected for processing (2)

• .github/workflows/connector-tests.yml (2 hunks)
• pyproject.toml (1 hunks)

🔇 Additional comments (2)

.github/workflows/connector-tests.yml (2)

89-92: LGTM! Re-enabling connectors looks good.

The addition of source-the-guardian-api and source-pokeapi to the matrix follows the established pattern and matches the PR objectives.

---

126-129: Verify the custom action parameters.

The switch to using the custom action looks good, but let's ensure all necessary parameters are being passed correctly.