Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix CI reports not uploading #138

Merged
merged 7 commits into from
Dec 5, 2024
Merged

ci: fix CI reports not uploading #138

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d0f4120
ci: provide a gcs report bucket name
aaronsteers Dec 5, 2024
57d4683
dummy change
aaronsteers Dec 5, 2024
3899e68
fix airbyte-ci syntax
aaronsteers Dec 5, 2024
44a5a56
evaluate results and post the url for easy viewing
aaronsteers Dec 5, 2024
a50c1b7
remove details url override attempt (not working)
aaronsteers Dec 5, 2024
491896d
Auto-fix lint and format issues
Dec 5, 2024
9748eae
Apply suggestions from code review
aaronsteers Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/connector-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ jobs:
# cdk_extra: n/a

name: "Check: '${{matrix.connector}}' (skip=${{needs.cdk_changes.outputs['src'] == 'false' || needs.cdk_changes.outputs[matrix.cdk_extra] == 'false'}})"
permissions:
checks: write
steps:
- name: Abort if extra not changed (${{matrix.cdk_extra}})
id: no_changes
Expand All @@ -119,7 +121,7 @@ jobs:
if: steps.no_changes.outputs.status != 'cancelled'
with:
repository: airbytehq/airbyte
ref: master
ref: aj/airbyte-ci/allow-report-uploads-with-fewer-permissions
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
path: airbyte
- name: Test Connector
if: steps.no_changes.outputs.status != 'cancelled'
Expand All @@ -131,15 +133,18 @@ jobs:
run: |
cd airbyte
make tools.airbyte-ci-dev.install
airbyte-ci-dev connectors \
airbyte-ci-dev \
--ci-report-bucket-name=airbyte-ci-reports-multi \
aaronsteers marked this conversation as resolved.
Show resolved Hide resolved
connectors \
--name ${{matrix.connector}} \
--use-local-cdk \
test \
--fail-fast \
--skip-step qa_checks \
--skip-step connector_live_tests

- name: Evaluate Test Output
- name: Evaluate Test
id: evaluate_output
if: always() && steps.no_changes.outputs.status != 'cancelled'
run: |
# save job output json file as ci step output
Expand All @@ -148,7 +153,9 @@ jobs:
success=$(echo ${job_output} | jq -r '.success')
failed_step=$(echo ${job_output} | jq -r '.failed_steps | select(length > 0) | .[0] // "None"')
run_duration=$(echo ${job_output} | jq -r '.run_duration')
html_report_url=$(echo ${job_output} | jq -r '.html_report_url')
echo "## Job Output for ${{matrix.connector}}" >> $GITHUB_STEP_SUMMARY
echo "- [HTML Report](${html_report_url})" >> $GITHUB_STEP_SUMMARY
echo "- Success: ${success}" >> $GITHUB_STEP_SUMMARY
echo "- Test Duration: $(printf "%.0f" ${run_duration})s" >> $GITHUB_STEP_SUMMARY
if [ "${success}" != "true" ]; then
Expand All @@ -159,6 +166,8 @@ jobs:
echo "::error::Test failed for connector '${{ matrix.connector }}' on step '${failed_step}'. Check the logs for more details."
exit 1
fi
echo "success=${success}" >> $GITHUB_OUTPUT
echo "html_report_url=${html_report_url}" >> $GITHUB_OUTPUT

# Upload the job output to the artifacts
- name: Upload Job Output
Expand Down
Loading