Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add
CustomSchemaNormalization
#194base: main
Are you sure you want to change the base?
feat: add
CustomSchemaNormalization
#194Changes from 5 commits
3984559
2433340
9bdfb73
c9202e5
26b99bf
8db550a
4f64a45
e7a6c0c
f787b6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably this
CustomNormalization
component would need to already adhere or inherit from theTypeTransformer
interface/class?And that's why we don't need to invoke the
TypeTransformer
constructor?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, most of the time we use
customtypetransformer
by registration some custom function, but generally speaking we need onlytransform
interface, I can add abstract class for thisairbyte-python-cdk/airbyte_cdk/sources/declarative/extractors/record_selector.py
Lines 110 to 116 in 3984559
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think we need to create an interface in the declarative package for this. I don't think we want users to be re-implementing
TypeTransformer
for a couple reasons:So we should just create a new TypeTransformer interface in low-code (i'll leave naming to you), and then I think
RecordSelector.schema_normalization
will need to be changed to a union of these two classes interfaces. Once we have these added will 👍 the PR. thanks for making the other adjustments!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added AbstractTypeTransformer