Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link HTML test reports in GitHub check results (#252) #257

Closed
wants to merge 18 commits into from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Link HTML test reports in GitHub check results

Resolves #252

Description

This PR enhances the connector tests workflow by linking the HTML test reports directly in GitHub's check results. When you click on the "Details" link in a check run (whether it passed or failed), it will take you directly to the HTML report if one was generated.

Changes:

  • Added step to obtain check run ID early in the job (before main tests) to keep logs organized
  • Added step to update check run's details_url to point to HTML report
  • The URL update happens for both successful and failed tests
  • Skip URL update only if report generation failed (URL is missing/null)

Testing

The changes can be tested by:

  1. Running the connector tests workflow
  2. Checking that the "Details" link in GitHub's checks UI points to the HTML report
  3. Verifying that the link works for both successful and failed test runs
  4. Confirming that when report generation fails, the link defaults to GitHub's standard logs

Link to Devin run: https://app.devin.ai/sessions/b2ee5a94ec1246878d249ba434684b31

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the enhancement New feature or request label Jan 23, 2025
@natikgadzhi
Copy link
Contributor

@aaronsteers wow! IF this works, this would be so cool

@aaronsteers
Copy link
Contributor

aaronsteers commented Jan 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Link to HTML test reports from CI checks list
2 participants