Skip to content

Commit

Permalink
source-snowflake: hide oauth option (#38317)
Browse files Browse the repository at this point in the history
  • Loading branch information
@evantahler
evantahler authored May 17, 2024
1 parent 91f1862 commit 010da0e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 18 deletions.
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-snowflake/metadata.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ data:
connectorSubtype: database
connectorType: source
definitionId: e2d65910-8c8b-40a1-ae7d-ee2416b2bfa2
dockerImageTag: 0.3.1
dockerImageTag: 0.3.2
dockerRepository: airbyte/source-snowflake
documentationUrl: https://docs.airbyte.com/integrations/sources/snowflake
githubIssueLabel: source-snowflake
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-snowflake/src/main/resources/spec.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"title": "OAuth2.0",
"order": 0,
"required": ["client_id", "client_secret", "auth_type"],
"airbyte_hidden": true,
"properties": {
"auth_type": {
"type": "string",
Expand Down
2 changes: 1 addition & 1 deletion ...ntegrations/connectors/source-snowflake/src/test-integration/resources/expected_spec.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"title": "OAuth2.0",
"order": 0,
"required": ["client_id", "client_secret", "auth_type"],
"airbyte_hidden": true,
"properties": {
"auth_type": {
"type": "string",
Expand Down Expand Up @@ -124,7 +125,6 @@
}
}
},
"supported_destination_sync_modes": [],
"advanced_auth": {
"auth_flow_type": "oauth2.0",
"predicate_key": ["credentials", "auth_type"],
Expand Down
19 changes: 3 additions & 16 deletions docs/integrations/sources/snowflake.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,9 @@ You can limit this grant down to specific schemas instead of the whole database.

Your database user should now be ready for use with Airbyte.

###Authentication
### Authentication

#### There are 2 way ways of oauth supported: login\pass and oauth2.

### Login and Password
#### Login and Password

| Field | Description |
| ----------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
Expand All @@ -89,18 +87,6 @@ Your database user should now be ready for use with Airbyte.
| Password | The password associated with the username. |
| [JDBC URL Params](https://docs.snowflake.com/en/user-guide/jdbc-parameters.html) (Optional) | Additional properties to pass to the JDBC URL string when connecting to the database formatted as `key=value` pairs separated by the symbol `&`. Example: `key1=value1&key2=value2&key3=value3` |

### OAuth 2.0

| Field | Description |
| ----------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| [Host](https://docs.snowflake.com/en/user-guide/admin-account-identifier.html) | The host domain of the snowflake instance (must include the account, region, cloud environment, and end with snowflakecomputing.com). Example: `accountname.us-east-2.aws.snowflakecomputing.com` |
| [Role](https://docs.snowflake.com/en/user-guide/security-access-control-overview.html#roles) | The role you created in Step 1 for Airbyte to access Snowflake. Example: `AIRBYTE_ROLE` |
| [Warehouse](https://docs.snowflake.com/en/user-guide/warehouses-overview.html#overview-of-warehouses) | The warehouse you created in Step 1 for Airbyte to sync data into. Example: `AIRBYTE_WAREHOUSE` |
| [Database](https://docs.snowflake.com/en/sql-reference/ddl-database.html#database-schema-share-ddl) | The database you created in Step 1 for Airbyte to sync data into. Example: `AIRBYTE_DATABASE` |
| [Schema](https://docs.snowflake.com/en/sql-reference/ddl-database.html#database-schema-share-ddl) | The schema whose tables this replication is targeting. If no schema is specified, all tables with permission will be presented regardless of their schema. |
| OAuth2 | The Login name and password to obtain auth token. |
| [JDBC URL Params](https://docs.snowflake.com/en/user-guide/jdbc-parameters.html) (Optional) | Additional properties to pass to the JDBC URL string when connecting to the database formatted as `key=value` pairs separated by the symbol `&`. Example: `key1=value1&key2=value2&key3=value3` |

### Network policies

By default, Snowflake allows users to connect to the service from any computer or device IP address. A security administrator (i.e. users with the SECURITYADMIN role) or higher can create a network policy to allow or deny access to a single IP address or a list of addresses.
Expand All @@ -127,6 +113,7 @@ To read more please check official [Snowflake documentation](https://docs.snowfl

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------------- |
| 0.3.2 | 2024-02-13 | [38317](https://github.com/airbytehq/airbyte/pull/38317) | Hide oAuth option from connector |
| 0.3.1 | 2024-02-13 | [35220](https://github.com/airbytehq/airbyte/pull/35220) | Adopt CDK 0.20.4 |
| 0.3.1 | 2024-01-24 | [34453](https://github.com/airbytehq/airbyte/pull/34453) | bump CDK version |
| 0.3.0 | 2023-12-18 | [33484](https://github.com/airbytehq/airbyte/pull/33484) | Remove LEGACY state |
Expand Down

0 comments on commit 010da0e

Please sign in to comment.