chore: remove metadata secrets that are no longer used. (#50885)

These secrets are no longer used in tests. Remove to make things less confusing for future work since I'm in this area now.
airbytehq · Jan 4, 2025 · 20004d4 · 20004d4
1 parent 46db5d6
commit 20004d4
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 73 deletions.
diff --git a/airbyte-integrations/connectors/destination-snowflake/README.md b/airbyte-integrations/connectors/destination-snowflake/README.md
@@ -30,13 +30,7 @@ Put the contents of the following LastPass secrets into corresponding files unde
 | LastPass Secret                                                                                        | File                                     |
 | ------------------------------------------------------------------------------------------------------ | ---------------------------------------- |
 | `destination snowflake - test creds (secrets/config.json)`                                             | `secrets/config.json`                    |
-| `destination snowflake - insert test creds (secrets/insert_config.json)`                               | `secrets/insert_config.json`             |
 | `destination snowflake - internal staging test creds (secrets/internal_staging_config.json)`           | `secrets/internal_staging_config.json`   |
-| `destination snowflake - internal staging key pair (secrets/config_key_pair.json)`                     | `secrets/config_key_pair.json`           |
-| `destination snowflake - internal staging key pair encrypted (secrets/config_key_pair_encrypted.json)` | `secrets/config_key_pair_encrypted.json` |
-| `destination snowflake - s3 staging test creds (secrets/copy_s3_config.json)`                          | `secrets/copy_s3_config.json`            |
-| `destination snowflake - s3 staging encrypted test creds (secrets/copy_s3_encrypted_config.json)`      | `secrets/copy_s3_encrypted_config.json`  |
-| `destination snowflake - gcs staging test creds (secrets/copy_gcs_config.json)`                        | `secrets/copy_gcs_config.json`           |
 
 The query timeout for insert data to table has been updated from 30 minutes to 3 hours.
 
@@ -104,5 +98,3 @@ create schema INTEGRATION_TEST_DESTINATION.TEXT_SCHEMA;
 grant ownership on schema INTEGRATION_TEST_DESTINATION.TEXT_SCHEMA to role INTEGRATION_TESTER_DESTINATION revoke current grants;
 grant all privileges on schema INTEGRATION_TEST_DESTINATION.TEXT_SCHEMA to role NO_ACTIVE_WAREHOUSE_ROLE;
 ```
-
-These tests are currently disabled (`testCheckWithNoProperStagingPermissionConnection`, `testCheckWithNoActiveWarehouseConnection`). Their test users keep breaking (i.e. becoming the schema owner) because our tests are tearing down `TEXT_SCHEMA` after every test.
diff --git a/airbyte-integrations/connectors/destination-snowflake/metadata.yaml b/airbyte-integrations/connectors/destination-snowflake/metadata.yaml
@@ -41,31 +41,6 @@ data:
     - suite: unitTests
     - suite: integrationTests
       testSecrets:
-        - name: SECRET_DESTINATION-SNOWFLAKE_COPY_AZURE_BLOB__CREDS
-          fileName: copy_azure_blob_config.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION-SNOWFLAKE_COPY_GCS__CREDS
-          fileName: copy_gcs_config.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION-SNOWFLAKE_COPY_S3_ENCRYPTED__CREDS
-          fileName: copy_s3_encrypted_config.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION-SNOWFLAKE_COPY_S3__CREDS
-          fileName: copy_s3_config.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION-SNOWFLAKE_INSUFFICIENT_GCS_ROLE__CREDS
-          fileName: copy_insufficient_gcs_roles_config.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
         - name: SECRET_DESTINATION-SNOWFLAKE_INTERNAL_STAGING_CONFIG_DISABLETD
           fileName: 1s1t_disabletd_internal_staging_config.json
           secretStore:
@@ -76,21 +51,6 @@ data:
           secretStore:
             type: GSM
             alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION-SNOWFLAKE_IP_NOT_IN_WHITELIST_CREDS
-          fileName: insert_ip_not_in_whitelist_config.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION-SNOWFLAKE_S3_WRONG_LOCATION__CREDS
-          fileName: copy_s3_wrong_location_config.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION-SNOWFLAKE_WITHOUT_INTERNAL_STAGING__CREDS
-          fileName: copy_insufficient_staging_roles_config.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
         - name: SECRET_DESTINATION_SNOWFLAKE_1S1T_INTERNAL_STAGING_CREDS
           fileName: 1s1t_internal_staging_config.json
           secretStore:
@@ -106,34 +66,9 @@ data:
           secretStore:
             type: GSM
             alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION_SNOWFLAKE_KEY_PAIR_ENCRYPTED__CREDS
-          fileName: config_key_pair_encrypted.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION_SNOWFLAKE_KEY_PAIR__CREDS
-          fileName: config_key_pair.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION_SNOWFLAKE_NO_ACTIVE_WAREHOUSE_CREDS
-          fileName: internal_staging_config_no_active_warehouse.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION_SNOWFLAKE_NO_CREATE_SCHEMA_PRIVILEGE
-          fileName: no_create_schema_privilege.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
         - name: SECRET_DESTINATION_SNOWFLAKE_QUOTED_IDENTIFIERS_IGNORE_CASE_CREDS
           fileName: 1s1t_case_insensitive.json
           secretStore:
             type: GSM
             alias: airbyte-connector-testing-secret-store
-        - name: SECRET_DESTINATION_SNOWFLAKE_TESTUSER_WITHOUT_TEXT_SCHEMA_PERMISSION_CREDS
-          fileName: config_no_text_schema_permission.json
-          secretStore:
-            type: GSM
-            alias: airbyte-connector-testing-secret-store
 metadataSpecVersion: "1.0"