fix: Resolves bug in s3 source that did not support tab as a delimiter.

airbytehq · Feb 13, 2024 · 6ce99e5 · 6ce99e5
1 parent f6b4436
commit 6ce99e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/airbyte-cdk/python/airbyte_cdk/sources/file_based/config/csv_format.py b/airbyte-cdk/python/airbyte_cdk/sources/file_based/config/csv_format.py
@@ -150,6 +150,8 @@ class Config(OneOfOptionConfig):
 
     @validator("delimiter")
     def validate_delimiter(cls, v: str) -> str:
+        if v == r'\t':
+            return v
         if len(v) != 1:
             raise ValueError("delimiter should only be one character")
         if v in {"\r", "\n"}:

diff --git a/airbyte-integrations/connectors/source-s3/unit_tests/v4/test_format.py b/airbyte-integrations/connectors/source-s3/unit_tests/v4/test_format.py
@@ -0,0 +1,4 @@
+from airbyte_cdk.sources.file_based.config.csv_format import CsvFormat
+
+def test_csv_format_tab_delimited():
+    assert CsvFormat(delimiter=r"\t").delimiter == '\\t'