feat: No longer make marketplace required reviewers for manifest-only…

… and support level community (#51527)
airbytehq · Jan 16, 2025 · 767e820 · 767e820
1 parent ab69b7d
commit 767e820
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 21 deletions.
diff --git a/airbyte-ci/connectors/connector_ops/connector_ops/required_reviewer_checks.py b/airbyte-ci/connectors/connector_ops/connector_ops/required_reviewer_checks.py
@@ -12,7 +12,6 @@
 # The breaking change reviewers is still in active use.
 BREAKING_CHANGE_REVIEWERS = {"breaking-change-reviewers"}
 CERTIFIED_MANIFEST_ONLY_CONNECTOR_REVIEWERS = {"dev-python"}
-COMMUNITY_MANIFEST_ONLY_CONNECTOR_REVIEWERS = {"dev-marketplace-contributions"}
 REVIEW_REQUIREMENTS_FILE_PATH = ".github/connector_org_review_requirements.yaml"
 
 
@@ -46,11 +45,6 @@ def find_mandatory_reviewers() -> List[Dict[str, Union[str, Dict[str, List]]]]:
             "teams": list(CERTIFIED_MANIFEST_ONLY_CONNECTOR_REVIEWERS),
             "is_required": find_changed_manifest_only_connectors(support_level="certified"),
         },
-        {
-            "name": "Manifest-only community connectors",
-            "teams": list(COMMUNITY_MANIFEST_ONLY_CONNECTOR_REVIEWERS),
-            "is_required": find_changed_manifest_only_connectors(support_level="community"),
-        },
     ]
 
     return [{"name": r["name"], "teams": r["teams"]} for r in requirements if r["is_required"]]

diff --git a/airbyte-ci/connectors/connector_ops/tests/test_required_reviewer_checks.py b/airbyte-ci/connectors/connector_ops/tests/test_required_reviewer_checks.py
@@ -53,17 +53,6 @@ def test_breaking_change_release_expected_team(tmp_path, pokeapi_metadata_path)
     shutil.copyfile(backup_path, pokeapi_metadata_path)
 
 
-@pytest.fixture
-def test_community_manifest_only_connector_expected_team(tmp_path, manifest_only_community_connector_path) -> List:
-    expected_teams = list(required_reviewer_checks.COMMUNITY_MANIFEST_ONLY_CONNECTOR_REVIEWERS)
-    backup_path = tmp_path / "backup_xkcd_metadata"
-    shutil.copyfile(manifest_only_community_connector_path, backup_path)
-    with open(manifest_only_community_connector_path, "a") as metadata_file:
-        metadata_file.write("anyKey: anyValue")
-    yield expected_teams
-    shutil.copyfile(backup_path, manifest_only_community_connector_path)
-
-
 @pytest.fixture
 def test_certified_manifest_only_connector_expected_team(tmp_path, manifest_only_community_connector_path) -> List:
     expected_teams = list(required_reviewer_checks.CERTIFIED_MANIFEST_ONLY_CONNECTOR_REVIEWERS)
@@ -113,9 +102,5 @@ def test_find_mandatory_reviewers_no_tracked_changed(capsys, not_tracked_change_
     check_review_requirements_file(capsys, not_tracked_change_expected_team)
 
 
-def test_find_reviewers_manifest_only_community_connector(capsys, test_community_manifest_only_connector_expected_team):
-    check_review_requirements_file(capsys, test_community_manifest_only_connector_expected_team)
-
-
 def test_find_reviewers_manifest_only_certified_connector(capsys, test_certified_manifest_only_connector_expected_team):
     check_review_requirements_file(capsys, test_certified_manifest_only_connector_expected_team)