Skip to content

Commit

Permalink
new connector for camunda-history
Browse files Browse the repository at this point in the history
  • Loading branch information
akozichev committed Jan 26, 2024
1 parent 9815a10 commit 9fa8ee2
Show file tree
Hide file tree
Showing 22 changed files with 2,839 additions and 0 deletions.
115 changes: 115 additions & 0 deletions airbyte-integrations/connectors/source-camunda-history/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
# Camunda History Source

This is the repository for the Camunda History configuration based source connector.
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.com/integrations/sources/camunda-history).

## Local development


#### Create credentials
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.com/integrations/sources/camunda-history)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_camunda_history/spec.yaml` file.
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information.
See `integration_tests/sample_config.json` for a sample config file.

**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source camunda-history test creds`
and place them into `secrets/config.json`.

### Locally running the connector docker image

#### Use `airbyte-ci` to build your connector
The Airbyte way of building this connector is to use our `airbyte-ci` tool.
You can follow install instructions [here](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md#L1).
Then running the following command will build your connector:

```bash
airbyte-ci connectors --name source-camunda-history build
```
Once the command is done, you will find your connector image in your local docker registry: `airbyte/source-camunda-history:dev`.

##### Customizing our build process
When contributing on our connector you might need to customize the build process to add a system dependency or set an env var.
You can customize our build process by adding a `build_customization.py` module to your connector.
This module should contain a `pre_connector_install` and `post_connector_install` async function that will mutate the base image and the connector container respectively.
It will be imported at runtime by our build process and the functions will be called if they exist.

Here is an example of a `build_customization.py` module:
```python
from __future__ import annotations

from typing import TYPE_CHECKING

if TYPE_CHECKING:
# Feel free to check the dagger documentation for more information on the Container object and its methods.
# https://dagger-io.readthedocs.io/en/sdk-python-v0.6.4/
from dagger import Container


async def pre_connector_install(base_image_container: Container) -> Container:
return await base_image_container.with_env_variable("MY_PRE_BUILD_ENV_VAR", "my_pre_build_env_var_value")

async def post_connector_install(connector_container: Container) -> Container:
return await connector_container.with_env_variable("MY_POST_BUILD_ENV_VAR", "my_post_build_env_var_value")
```

#### Build your own connector image
This connector is built using our dynamic built process in `airbyte-ci`.
The base image used to build it is defined within the metadata.yaml file under the `connectorBuildOptions`.
The build logic is defined using [Dagger](https://dagger.io/) [here](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/pipelines/builds/python_connectors.py).
It does not rely on a Dockerfile.

If you would like to patch our connector and build your own a simple approach would be to:

1. Create your own Dockerfile based on the latest version of the connector image.
```Dockerfile
FROM airbyte/source-camunda-history:latest

COPY . ./airbyte/integration_code
RUN pip install ./airbyte/integration_code

# The entrypoint and default env vars are already set in the base image
# ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
# ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
```
Please use this as an example. This is not optimized.

2. Build your image:
```bash
docker build -t airbyte/source-camunda-history:dev .
# Running the spec command against your patched connector
docker run airbyte/source-camunda-history:dev spec

#### Run
Then run any of the connector commands as follows:
```
docker run --rm airbyte/source-camunda-history:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-camunda-history:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-camunda-history:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-camunda-history:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
```
## Testing
### Acceptance Tests
Customize `acceptance-test-config.yml` file to configure tests. See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) for more information.
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
Please run acceptance tests via [airbyte-ci](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md#connectors-test-command):
```bash
airbyte-ci connectors --name source-camunda-history test
```

## Dependency Management
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development.
We split dependencies between two groups, dependencies that are:
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list.
* required for the testing need to go to `TEST_REQUIREMENTS` list

### Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing our test suite: `airbyte-ci connectors --name=source-camunda-history test`
2. Bump the connector version in `metadata.yaml`: increment the `dockerImageTag` value. Please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors).
3. Make sure the `metadata.yaml` content is up to date.
4. Make the connector documentation and its changelog is up to date (`docs/integrations/sources/camunda-history.md`).
5. Create a Pull Request: use [our PR naming conventions](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#pull-request-title-convention).
6. Pat yourself on the back for being an awesome contributor.
7. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
connector_image: airbyte/source-camunda-history:dev
acceptance_tests:
spec:
tests:
- spec_path: "source_camunda_history/spec.yaml"
connection:
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
tests:
- config_path: "secrets/config.json"
basic_read:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams:
- name: "batch"
bypass_reason: "Endpoint not allowed in integration account"
- name: "decision-instance"
bypass_reason: "Endpoint not allowed in integration account"
- name: "task-startedAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "task-finishedAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "case-instance-closedAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "case-instance-createdAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "process-instance-startedAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "activity-instance-startedAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "process-instance-finishedAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "activity-instance-finishedAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "case-activity-instance-endedAfter"
bypass_reason: "Endpoint not allowed in integration account"
- name: "case-activity-instance-createdAfter"
bypass_reason: "Endpoint not allowed in integration account"
incremental:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
future_state:
future_state_path: "integration_tests/abnormal_state.json"
full_refresh:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
21 changes: 21 additions & 0 deletions airbyte-integrations/connectors/source-camunda-history/icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"activity-instance-startedAfter": {
"startTime": "2924-01-19T13:39:01.170+0000"
},
"activity-instance-finishedAfter": {
"endTime": "2924-01-19T13:39:01.170+0000"
},
"decision-instance": {
"evaluationTime": "2924-01-19T13:39:01.170+0000"
},
"process-instance-startedAfter": {
"startTime": "2924-01-19T13:39:01.170+0000"
},
"process-instance-finishedAfter": {
"endTime": "2924-01-19T13:39:01.170+0000"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#


import pytest

pytest_plugins = ("connector_acceptance_test.plugin",)


@pytest.fixture(scope="session", autouse=True)
def connector_setup():
"""This fixture is a placeholder for external resources that acceptance test might require."""
# TODO: setup test dependencies if needed. otherwise remove the TODO comments
yield
# TODO: clean up test dependencies
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"baseurl": "http://localhost:8090/engine-rest",
"batchsize": "100",
"start_date": "2024-01-01T00:00:00Z",
"username": "anonymous"
}
Loading

0 comments on commit 9fa8ee2

Please sign in to comment.