Skip to content

Commit

Permalink
Source Apple Search Ads(fix): fix authentication grant_type (#48440)
Browse files Browse the repository at this point in the history
  • Loading branch information
ChristoGrab authored Nov 12, 2024
1 parent 53fce2c commit a6fe0dc
Show file tree
Hide file tree
Showing 4 changed files with 50 additions and 40 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,43 +8,43 @@ acceptance_tests:
connection:
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
tests:
- config_path: "secrets/config.json"
basic_read:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: []
timeout_seconds: 3600
incremental:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
future_state:
future_state_path: "integration_tests/abnormal_state.json"
timeout_seconds: 3600
full_refresh:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
ignored_fields:
adgroups_report_daily:
- name: granularity
bypass_reason: "Can't be idempotent by nature"
- name: metadata
bypass_reason: "Can't be idempotent by nature"
campaigns_report_daily:
- name: granularity
bypass_reason: "Can't be idempotent by nature"
- name: metadata
bypass_reason: "Can't be idempotent by nature"
keywords_report_daily:
- name: granularity
bypass_reason: "Can't be idempotent by nature"
- name: metadata
bypass_reason: "Can't be idempotent by nature"
timeout_seconds: 3600

## Uncomment the following tests and mark above connection test status as "succeeded" when we have a usable sandbox environment
# discovery:
# tests:
# - config_path: "secrets/config.json"
# basic_read:
# tests:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
# empty_streams: []
# timeout_seconds: 3600
# incremental:
# tests:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
# future_state:
# future_state_path: "integration_tests/abnormal_state.json"
# timeout_seconds: 3600
# full_refresh:
# tests:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
# ignored_fields:
# adgroups_report_daily:
# - name: granularity
# bypass_reason: "Can't be idempotent by nature"
# - name: metadata
# bypass_reason: "Can't be idempotent by nature"
# campaigns_report_daily:
# - name: granularity
# bypass_reason: "Can't be idempotent by nature"
# - name: metadata
# bypass_reason: "Can't be idempotent by nature"
# keywords_report_daily:
# - name: granularity
# bypass_reason: "Can't be idempotent by nature"
# - name: metadata
# bypass_reason: "Can't be idempotent by nature"
# timeout_seconds: 3600
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ definitions:
type: OAuthAuthenticator
client_id: "{{ config.client_id }}"
client_secret: "{{ config.client_secret }}"
grant_type: client_credentials
token_refresh_endpoint: >-
https://appleid.apple.com/auth/oauth2/token?grant_type=client_credentials&scope=searchadsorg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: e59c8416-c2fa-4bd3-9e95-52677ea281c1
dockerImageTag: 0.2.0
dockerImageTag: 0.2.1
dockerRepository: airbyte/source-apple-search-ads
githubIssueLabel: source-apple-search-ads
icon: apple.svg
Expand All @@ -25,6 +25,14 @@ data:
ab_internal:
sl: 100
ql: 100
connectorTestSuitesOptions:
- suite: acceptanceTests
testSecrets:
- name: SECRET_SOURCE-APPLE-SEARCH-ADS__CREDS
fileName: config.json
secretStore:
type: GSM
alias: airbyte-connector-testing-secret-store
supportLevel: community
connectorBuildOptions:
baseImage: docker.io/airbyte/source-declarative-manifest:5.7.5@sha256:4832cc13b262b4cae4ba72b07da544e6ee2f5d216b7147483480d5ebc5d0d7ca
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/apple-search-ads.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ However, at this moment and as indicated in the stream names, the connector only

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :----------------------------------------------------------------------------------- |
| 0.2.1 | 2024-11-08 | [48440](https://github.com/airbytehq/airbyte/pull/48440) | Set authentication grant_type to client_credentials |
| 0.2.0 | 2024-10-01 | [46288](https://github.com/airbytehq/airbyte/pull/46288) | Migrate to Manifest-only |
| 0.1.20 | 2024-09-28 | [46153](https://github.com/airbytehq/airbyte/pull/46153) | Update dependencies |
| 0.1.19 | 2024-09-21 | [45803](https://github.com/airbytehq/airbyte/pull/45803) | Update dependencies |
Expand Down

0 comments on commit a6fe0dc

Please sign in to comment.