Skip to content

Commit

Permalink
airbyte-ci: remove deprecated --no-update flag from poetry commands (#…
Browse files Browse the repository at this point in the history
…50988)

Co-authored-by: Octavia Squidington III <[email protected]>
  • Loading branch information
ChristoGrab and octavia-squidington-iii authored Jan 8, 2025
1 parent 7f98173 commit b8f4274
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 9 deletions.
1 change: 1 addition & 0 deletions airbyte-ci/connectors/pipelines/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,7 @@ airbyte-ci connectors --language=low-code migrate-to-manifest-only

| Version | PR | Description |
|---------|------------------------------------------------------------| ---------------------------------------------------------------------------------------------------------------------------- |
| 4.48.3 | [#50988](https://github.com/airbytehq/airbyte/pull/50988) | Remove deprecated `--no-update` flag from poetry commands |
| 4.48.2 | [#50871](https://github.com/airbytehq/airbyte/pull/50871) | Speed up connector modification detection. |
| 4.48.1 | [#50410](https://github.com/airbytehq/airbyte/pull/50410) | Java connector build: give ownership of built artifacts to the current image user. |
| 4.48.0 | [#49960](https://github.com/airbytehq/airbyte/pull/49960) | Deprecate airbyte-ci format command |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ def _build_erd_container(self, connector_directory: Directory, discovered_catalo
.with_workdir("/app")
)

return container.with_exec(["poetry", "lock", "--no-update"], use_entrypoint=True).with_exec(
["poetry", "install"], use_entrypoint=True
)
return container.with_exec(["poetry", "lock"], use_entrypoint=True).with_exec(["poetry", "install"], use_entrypoint=True)


class UploadDbmlSchema(Step):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,5 @@ async def _build_test_container(self, target_container_id: str) -> Container:
)
)

container = container.with_exec(["poetry", "lock", "--no-update"], use_entrypoint=True).with_exec(
["poetry", "install"], use_entrypoint=True
)
container = container.with_exec(["poetry", "lock"], use_entrypoint=True).with_exec(["poetry", "install"], use_entrypoint=True)
return container
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ async def upgrade_cdk_version_for_python_connector(self, og_connector_dir: Direc
connector_container = base_container.with_mounted_directory("/connector", updated_connector_dir).with_workdir("/connector")

poetry_lock_file = await connector_container.file(POETRY_LOCK_FILENAME).contents()
updated_container = await connector_container.with_exec(["poetry", "lock", "--no-update"], use_entrypoint=True)
updated_container = await connector_container.with_exec(["poetry", "lock"], use_entrypoint=True)
updated_poetry_lock_file = await updated_container.file(POETRY_LOCK_FILENAME).contents()

if poetry_lock_file != updated_poetry_lock_file:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def prepare_container_for_poe_tasks(
],
use_entrypoint=True,
)
.with_exec(["poetry", "lock", "--no-update"], use_entrypoint=True)
.with_exec(["poetry", "lock"], use_entrypoint=True)
)

# Install the poetry package
Expand Down
2 changes: 1 addition & 1 deletion airbyte-ci/connectors/pipelines/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "pipelines"
version = "4.48.2"
version = "4.48.3"
description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
authors = ["Airbyte <[email protected]>"]

Expand Down

0 comments on commit b8f4274

Please sign in to comment.