Skip to content

Commit

Permalink
[medatada_lib] cleanup connector exceptions list (#38015)
Browse files Browse the repository at this point in the history
  • Loading branch information
natikgadzhi authored May 8, 2024
1 parent f34518b commit c2d133d
Showing 1 changed file with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,6 @@ class ValidatorOptions:
ValidationResult = Tuple[bool, Optional[Union[ValidationError, str]]]
Validator = Callable[[ConnectorMetadataDefinitionV0, ValidatorOptions], ValidationResult]

# TODO: Remove these when each of these connectors ship any new version
ALREADY_ON_MAJOR_VERSION_EXCEPTIONS = [
("airbyte/source-prestashop", "1.0.0"),
("airbyte/source-yandex-metrica", "1.0.0"),
("airbyte/destination-csv", "1.0.0"),
]


def validate_metadata_images_in_dockerhub(
metadata_definition: ConnectorMetadataDefinitionV0, validator_opts: ValidatorOptions
Expand Down Expand Up @@ -109,14 +102,7 @@ def validate_major_version_bump_has_breaking_change_entry(
if not is_major_version(image_tag):
return True, None

# Some connectors had just done major version bumps when this check was introduced.
# These do not need breaking change entries for these specific versions.
# Future versions will still be validated to make sure an entry exists.
# See comment by ALREADY_ON_MAJOR_VERSION_EXCEPTIONS for how to get rid of this list.
docker_repo = get(metadata_definition_dict, "data.dockerRepository")
if (docker_repo, image_tag) in ALREADY_ON_MAJOR_VERSION_EXCEPTIONS:
return True, None

releases = get(metadata_definition_dict, "data.releases")
if not releases:
return (
Expand Down

0 comments on commit c2d133d

Please sign in to comment.