Merge branch 'master' into iceberg-schema-comparator

.github/workflows/airbyte-ci-release.yml

@@ -43,6 +43,8 @@ jobs:
       - name: Install Poetry
         id: install_poetry
         uses: snok/install-poetry@v1
+        with:
+          version: 1.8.5
 
       - name: Install Dependencies
         id: install_dependencies

.github/workflows/auto_merge.yml

@@ -18,6 +18,8 @@ jobs:
           python-version: "3.10"
       - name: Install and configure Poetry
         uses: snok/install-poetry@v1
+        with:
+          version: 1.8.5
       - name: Run auto merge
         shell: bash
         working-directory: airbyte-ci/connectors/auto_merge

.github/workflows/connectors_insights.yml

@@ -31,6 +31,7 @@ jobs:
       - name: Install Poetry
         uses: snok/install-poetry@v1
         with:
+          version: 1.8.5
           virtualenvs-create: true
           virtualenvs-in-project: true
           installer-parallel: true

.github/workflows/live_tests.yml

@@ -63,6 +63,8 @@ jobs:
       - name: Install Poetry
         id: install_poetry
         uses: snok/install-poetry@v1
+        with:
+          version: 1.8.5
 
       - name: Make poetry venv in project
         id: poetry_venv

.github/workflows/regression_tests.yml

@@ -63,6 +63,8 @@ jobs:
       - name: Install Poetry
         id: install_poetry
         uses: snok/install-poetry@v1
+        with:
+          version: 1.8.5
 
       - name: Make poetry venv in project
         id: poetry_venv

airbyte-cdk/bulk/core/base/src/main/kotlin/io/airbyte/cdk/ConnectorUncleanExitException.kt

@@ -6,4 +6,4 @@ package io.airbyte.cdk
 
 /** This is used only in tests. */
 class ConnectorUncleanExitException(val exitCode: Int) :
-    Exception("Destination process exited uncleanly: $exitCode")
+    Exception("Connector process exited uncleanly: $exitCode")

airbyte-cdk/bulk/core/load/src/integrationTest/kotlin/io/airbyte/cdk/load/mock_integration_test/MockBasicFunctionalityIntegrationTest.kt

@@ -5,8 +5,8 @@
 package io.airbyte.cdk.load.mock_integration_test
 
 import io.airbyte.cdk.load.test.util.NoopDestinationCleaner
-import io.airbyte.cdk.load.test.util.NoopExpectedRecordMapper
 import io.airbyte.cdk.load.test.util.NoopNameMapper
+import io.airbyte.cdk.load.test.util.UncoercedExpectedRecordMapper
 import io.airbyte.cdk.load.write.BasicFunctionalityIntegrationTest
 import io.airbyte.cdk.load.write.Untyped
 import org.junit.jupiter.api.Disabled
@@ -18,7 +18,7 @@ class MockBasicFunctionalityIntegrationTest :
         MockDestinationSpecification::class.java,
         MockDestinationDataDumper,
         NoopDestinationCleaner,
-        NoopExpectedRecordMapper,
+        UncoercedExpectedRecordMapper,
         NoopNameMapper,
         isStreamSchemaRetroactive = false,
         supportsDedup = true,
@@ -27,6 +27,7 @@ class MockBasicFunctionalityIntegrationTest :
         preserveUndeclaredFields = true,
         commitDataIncrementally = false,
         allTypesBehavior = Untyped,
+        envVars = emptyMap(),
         supportFileTransfer = false,
     ) {
     @Test

airbyte-cdk/bulk/core/load/src/main/kotlin/io/airbyte/cdk/load/data/AirbyteValue.kt

@@ -12,7 +12,6 @@ import java.time.LocalDateTime
 import java.time.LocalTime
 import java.time.OffsetDateTime
 import java.time.OffsetTime
-import java.time.ZoneOffset
 
 sealed interface AirbyteValue {
     companion object {
@@ -27,11 +26,11 @@ sealed interface AirbyteValue {
                 is BigInteger -> IntegerValue(value)
                 is Double -> NumberValue(BigDecimal.valueOf(value))
                 is BigDecimal -> NumberValue(value)
-                is LocalDate -> DateValue(value.toString())
-                is OffsetDateTime,
-                is LocalDateTime -> TimestampValue(value.toString())
-                is OffsetTime,
-                is LocalTime -> TimeValue(value.toString())
+                is LocalDate -> DateValue(value)
+                is OffsetDateTime -> TimestampWithTimezoneValue(value)
+                is LocalDateTime -> TimestampWithoutTimezoneValue(value)
+                is OffsetTime -> TimeWithTimezoneValue(value)
+                is LocalTime -> TimeWithoutTimezoneValue(value)
                 is Map<*, *> ->
                     ObjectValue.from(@Suppress("UNCHECKED_CAST") (value as Map<String, Any?>))
                 is List<*> -> ArrayValue.from(value)
@@ -73,76 +72,37 @@ value class NumberValue(val value: BigDecimal) : AirbyteValue, Comparable<Number
 }
 
 @JvmInline
-value class DateValue(val value: String) : AirbyteValue, Comparable<DateValue> {
-    override fun compareTo(other: DateValue): Int {
-        val thisDate =
-            try {
-                LocalDate.parse(value)
-            } catch (e: Exception) {
-                LocalDate.MIN
-            }
-        val otherDate =
-            try {
-                LocalDate.parse(other.value)
-            } catch (e: Exception) {
-                LocalDate.MIN
-            }
-        return thisDate.compareTo(otherDate)
-    }
+value class DateValue(val value: LocalDate) : AirbyteValue, Comparable<DateValue> {
+    constructor(date: String) : this(LocalDate.parse(date))
+    override fun compareTo(other: DateValue): Int = value.compareTo(other.value)
 }
 
 @JvmInline
-value class TimestampValue(val value: String) : AirbyteValue, Comparable<TimestampValue> {
-    override fun compareTo(other: TimestampValue): Int {
-        // Do all comparisons using OffsetDateTime for convenience.
-        // First, try directly parsing as OffsetDateTime.
-        // If that fails, try parsing as LocalDateTime and assume UTC.
-        // We could maybe have separate value classes for these cases,
-        // but that comes with its own set of problems
-        // (mostly around sources declaring bad schemas).
-        val thisTimestamp =
-            try {
-                OffsetDateTime.parse(value)
-            } catch (e: Exception) {
-                LocalDateTime.parse(value).atOffset(ZoneOffset.UTC)
-            } catch (e: Exception) {
-                LocalDateTime.MIN.atOffset(ZoneOffset.UTC)
-            }
-        val otherTimestamp =
-            try {
-                OffsetDateTime.parse(other.value)
-            } catch (e: Exception) {
-                LocalDateTime.parse(other.value).atOffset(ZoneOffset.UTC)
-            } catch (e: Exception) {
-                LocalDateTime.MIN.atOffset(ZoneOffset.UTC)
-            }
-        return thisTimestamp.compareTo(otherTimestamp)
-    }
+value class TimestampWithTimezoneValue(val value: OffsetDateTime) :
+    AirbyteValue, Comparable<TimestampWithTimezoneValue> {
+    constructor(timestamp: String) : this(OffsetDateTime.parse(timestamp))
+    override fun compareTo(other: TimestampWithTimezoneValue): Int = value.compareTo(other.value)
 }
 
 @JvmInline
-value class TimeValue(val value: String) : AirbyteValue, Comparable<TimeValue> {
-    override fun compareTo(other: TimeValue): Int {
-        // Similar to TimestampValue, try parsing with/without timezone,
-        // and do all comparisons using OffsetTime.
-        val thisTime =
-            try {
-                OffsetTime.parse(value)
-            } catch (e: Exception) {
-                LocalTime.parse(value).atOffset(ZoneOffset.UTC)
-            } catch (e: Exception) {
-                LocalTime.MIN.atOffset(ZoneOffset.UTC)
-            }
-        val otherTime =
-            try {
-                OffsetTime.parse(other.value)
-            } catch (e: Exception) {
-                LocalTime.parse(other.value).atOffset(ZoneOffset.UTC)
-            } catch (e: Exception) {
-                LocalTime.MIN.atOffset(ZoneOffset.UTC)
-            }
-        return thisTime.compareTo(otherTime)
-    }
+value class TimestampWithoutTimezoneValue(val value: LocalDateTime) :
+    AirbyteValue, Comparable<TimestampWithoutTimezoneValue> {
+    constructor(timestamp: String) : this(LocalDateTime.parse(timestamp))
+    override fun compareTo(other: TimestampWithoutTimezoneValue): Int = value.compareTo(other.value)
+}
+
+@JvmInline
+value class TimeWithTimezoneValue(val value: OffsetTime) :
+    AirbyteValue, Comparable<TimeWithTimezoneValue> {
+    constructor(time: String) : this(OffsetTime.parse(time))
+    override fun compareTo(other: TimeWithTimezoneValue): Int = value.compareTo(other.value)
+}
+
+@JvmInline
+value class TimeWithoutTimezoneValue(val value: LocalTime) :
+    AirbyteValue, Comparable<TimeWithoutTimezoneValue> {
+    constructor(time: String) : this(LocalTime.parse(time))
+    override fun compareTo(other: TimeWithoutTimezoneValue): Int = value.compareTo(other.value)
 }
 
 @JvmInline