Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[source-mysql] 3.9.0-rc.25 doesn't import view table anymore #49804

Closed
1 task
oliviertassinari opened this issue Dec 15, 2024 · 6 comments · Fixed by #50437
Closed
1 task

[source-mysql] 3.9.0-rc.25 doesn't import view table anymore #49804

oliviertassinari opened this issue Dec 15, 2024 · 6 comments · Fixed by #50437
Assignees
@rodireich
Labels
area/connectors Connector related issues autoteam community connectors/source/mysql team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/bug Something isn't working

Comments

@oliviertassinari
Copy link

oliviertassinari commented Dec 15, 2024 •
edited
Loading

Connector Name

source-mysql

Connector Version

3.9.0-rc.25

What step the error happened?

During the sync

Relevant information

This logic is wrong:

airbyte/airbyte-integrations/connectors/source-mysql/src/main/kotlin/io/airbyte/integrations/source/mysql/MysqlSourceOperations.kt

Lines 222 to 224 in bec1c44

val quickCount =
"SELECT GREATEST(10, table_rows) FROM information_schema.tables WHERE table_schema = '$namespace' AND table_name = '$name'"
val greatest = "GREATEST($greatestRate, $sampleSize / ($quickCount))" 

SELECT GREATEST(null, 1);
-- returns `NULL`, MySQL v8.0.39-30.

Why does it happen? Because I'm syncing a view (TABLE_TYPE = VIEW), it's not a regular table:

SCR-20241210-nidm

So I believe #48035 is not correct.

Relevant log output

We used to sync all the records with:

SCR-20241210-nglt

https://cloud.airbyte.com/workspaces/9e090881-de2e-48c7-b268-2e86ad2525d9/connections/b46a92b8-8aa3-44e9-b17a-26067781a1cc/timeline

and now since https://cloud.airbyte.com/workspaces/9e090881-de2e-48c7-b268-2e86ad2525d9/connections/b46a92b8-8aa3-44e9-b17a-26067781a1cc/timeline

SCR-20241210-ngqb

It syncs 0 records.

Contribute
@oliviertassinari oliviertassinari added area/connectors Connector related issues needs-triage type/bug Something isn't working labels Dec 15, 2024
@oliviertassinari oliviertassinari mentioned this issue Dec 15, 2024
Merged
2 tasks
@marcosmarxm
Copy link
Member

Thank you for reporting the issue, @oliviertassinari. @xiaohansong and @rodireich, could someone have a look into this?

@marcosmarxm marcosmarxm added connectors/source/mysql team/db-dw-sources Backlog for Database and Data Warehouse Sources team and removed needs-triage team/connectors-python labels Dec 16, 2024
@rodireich
Copy link
Contributor

Thanks I'm taking a look.

@rodireich rodireich self-assigned this Dec 19, 2024
@rodireich
Copy link
Contributor

[connection]
Another workspace with the same issue.
We rolled them back to legacy mysql until we get Views working

thanks @yardencarmeli

@oliviertassinari
Copy link
Author

oliviertassinari commented Dec 21, 2024 •
edited
Loading

Another workspace with the same issue.

@rodireich It's the same workplace, actually.

We rolled them back to legacy mysql until we get Views working

Thanks, I couldn't find how to do it with the UI. Seems impossible, maybe another feature request?

Why was it upgraded to an unstable version in the first place (RC)? Could this be another bug? It looks like https://docs.airbyte.com/managing-airbyte/connector-updates#airbyte-cloud is not how it behaves in practice. Minor, patch, aren't applied, e.g. MySQL. Major aren't applied e.g. PostgreSQL or not correctly, e.g. MySQL. The self-hosting path looks better than current Cloud behavior. Even better would be https://www.getdbt.com/blog/introducing-release-tracks-for-dbt-version-upgrades.

@rodireich rodireich linked a pull request Dec 28, 2024 that will close this issue
Make sample query compatible with views #50437
Merged
2 tasks
@octavia-squidington-iii
Copy link
Collaborator

Zendesk ticket #9642 has been linked to this issue.

@octavia-squidington-iii
Copy link
Collaborator

Zendesk ticket #9484 has been linked to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodireich rodireich

Labels
area/connectors Connector related issues autoteam community connectors/source/mysql team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sample query compatible with views airbytehq/airbyte
4 participants
@rodireich @oliviertassinari @marcosmarxm @octavia-squidington-iii