[source-mysql] No empty sample #48545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
rodireich
approved these changes
Nov 18, 2024
tryangul
pushed a commit
that referenced
this pull request
Nov 20, 2024
tryangul
pushed a commit
that referenced
this pull request
Nov 21, 2024
| val quickCount = | ||
| "SELECT table_rows FROM information_schema.tables WHERE table_schema = '$namespace' AND table_name = '$name'" | ||
| "SELECT GREATEST(10, table_rows) FROM information_schema.tables WHERE table_schema = '$namespace' AND table_name = '$name'" |
There was a problem hiding this comment.
I'm not convinced this is working. I have:
(SELECT GREATEST(10, table_rows) FROM information_schema.tables WHERE table_schema = 'sghost05_wp789' AND table_name = 'view_orders')that returns NULL on my end. MySQL v8.0.39-30.
We used to sync all the records with:
It syncs 0 records.
Why does it happen? Because I'm syncing a view (TABLE_TYPE = VIEW), it's not a regular table:
The logic in #48035 doesn't look correct.
There was a problem hiding this comment.
Moved to a dedicated issue #49804.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://github.com/airbytehq/airbyte-internal-issues/issues/10773
(without fix it was loading 0 records because it thought table is empty; after the fix it can load the record and successfully exit)
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?