Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Destination snowflake: fix check #34528

Merged
merged 3 commits into from
Jan 25, 2024
Merged

🐛 Destination snowflake: fix check #34528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ee8d17
try this?
edgao Jan 25, 2024
d60b0e0
logistics
edgao Jan 25, 2024
a56e8f2
unpin
edgao Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions airbyte-integrations/connectors/destination-snowflake/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: database
connectorType: destination
definitionId: 424892c4-daac-4491-b35d-c6688ba547ba
dockerImageTag: 3.5.2
dockerImageTag: 3.5.3
dockerRepository: airbyte/destination-snowflake
documentationUrl: https://docs.airbyte.com/integrations/destinations/snowflake
githubIssueLabel: destination-snowflake
Expand All @@ -14,12 +14,8 @@ data:
name: Snowflake
registries:
cloud:
# 3.5.2 is broken; pinning back to the last known-good version
dockerImageTag: 3.4.22
enabled: true
oss:
# 3.5.2 is broken; pinning back to the last known-good version
dockerImageTag: 3.4.22
enabled: true
releaseStage: generally_available
releases:
Expand Down
5 changes: 3 additions & 2 deletions ...e/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeSqlOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,9 @@ public void insertRecordsInternal(final JdbcDatabase database,
@Override
protected void insertRecordsInternalV2(final JdbcDatabase jdbcDatabase, final List<PartialAirbyteMessage> list, final String s, final String s1)
throws Exception {
// Snowflake doesn't have standard inserts... so we probably never want to do this
throw new UnsupportedOperationException("Snowflake does not use the native JDBC DV2 interface");
// Snowflake doesn't have standard inserts... so we don't do this at real runtime.
// Intentionally do nothing. This method is called from the `check` method.
// It probably shouldn't be, but this is the easiest path to getting this working.
}

protected String generateFilesList(final List<String> files) {
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/destinations/snowflake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ Otherwise, make sure to grant the role the required permissions in the desired n

| Version | Date | Pull Request | Subject |
|:----------------|:-----------|:-----------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 3.5.3 | 2024-01-25 | [\#34528](https://github.com/airbytehq/airbyte/pull/34528) | Fix spurious `check` failure (`UnsupportedOperationException: Snowflake does not use the native JDBC DV2 interface`) |
| 3.5.2 | 2024-01-24 | [\#34458](https://github.com/airbytehq/airbyte/pull/34458) | Improve error reporting |
| 3.5.1 | 2024-01-24 | [\#34501](https://github.com/airbytehq/airbyte/pull/34501) | Internal code changes for Destinations V2 |
| 3.5.0 | 2024-01-24 | [\#34462](https://github.com/airbytehq/airbyte/pull/34462) | Upgrade CDK to 0.14.0 |
Expand Down
Loading