-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Kyriba: Updates CDK, Increases Testing Coverage, Fixes Acceptance Test Config, Adds Expected Records #34545
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pnilan , From description
Updates Docker build Python version to 3.10
We can get rid of Dockerfile
and use our base image docker.io/airbyte/python-connector-base
…flows` and `bank_balances_intraday` streams.
…nce Test Config, Adds Expected Records (#34545)
…nce Test Config, Adds Expected Records (airbytehq#34545)
…nce Test Config, Adds Expected Records (airbytehq#34545)
…nce Test Config, Adds Expected Records (airbytehq#34545)
…nce Test Config, Adds Expected Records (#34545)
What
acceptance-test-config
for all tests to runadditionalProperties
to true for all streamsfails_on_extra_column
to false inacceptance_test_config
cash_flows
andbank_balances_intraday
streams