-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine TransactionsGraphql and Transactions streams into a single Transactions stream in the catalog #34546
Combine TransactionsGraphql and Transactions streams into a single Transactions stream in the catalog #34546
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
… alex/shopify_bulk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of connector ops the change to the acceptance-test-config.yml
file.
… alex/shopify_bulk
… alex/shopify_bulk
closing because this was already added to #32345 |
What
How
select_transactions_stream
to return the right implementation for the transactions stream instead of filtering them from the list of streamsRecommended reading order
airbyte-integrations/connectors/source-shopify/source_shopify/source.py
airbyte-integrations/connectors/source-shopify/source_shopify/streams/streams.py
airbyte-integrations/connectors/source-shopify/unit_tests/test_source.py
airbyte-integrations/connectors/source-shopify/integration_tests/configured_catalog.json
airbyte-integrations/connectors/source-shopify/acceptance-test-config.yml