-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor debezium harness in CDK, push connector-specific logic down to connectors #34573
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Coverage report for source-postgres
|
5d1c30a
to
ab660f4
Compare
ab660f4
to
7fcef6a
Compare
/publish-java-cdk
|
This reverts commit 932032c.
/approve-and-merge reason="source-mysql has flaky tests, not related to changes here" |
In the course of restructuring the CDK I stumbled on the tangled knot of dependencies that was our debezium harness. This PR untangles it. Debezium-with-mongo code is moved out of the CDK and into source-mongodb-v2, same with postgres and mysql. @stephane-airbyte had already taken care of mssql.
This is best reviewed commit-by-commit. First we have the version number change boilerplate. The next commits, up to but not including the last, work towards removing the
DebeziumConnectorType
enum from the debezium harness. This makes it possible to inject mongo-specific-dependencies intoAirbyteDebeziumHandler
instead of dispatching on that enum value deeper down. Once that is done, the final commit straightforwardly moves the connector-specific source files from the CDK to the respective connectors.