Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Zoom: Fix authenticator bug and add missing fields #35369

Merged
merged 40 commits into from
Mar 12, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Feb 16, 2024

What

The Zoom connector has been down for some time, and due to lacking a sandbox account the updates to the authenticator introduced in 1.0.0 were never published. A test account has now been set up, and we are able to at least verify the ability to connect successfully to the API and sync data for multiple streams. All webinar streams remain untested at this time, and we do not currently plan to add integration tests for these streams as this is a Community connector.

How

Bugs

  • Fixed auth_headers call in authenticator to return string rather than a dict
  • Updated authenticator test to match actual implementation (grant_type is not set in config)

Schemas

  • Added placeholder schemas for the transient meeting_list_tmp and webinar_list_tmp parent streams.
  • Added missing fields to schemas and retyped meeting_id property in meeting_registration_questions stream

QA

  • Updated test-config to current format
  • Migrated to base image and moved dependency management to poetry
  • Re-enabled the connector in registries

🚨🚨 User Impact

Users will be able to create connections and sync data again. This is a breaking change due to the new authenticator introduced in 1.0.0 and a retyped schema property. Users with existing connections will need to migrate by setting up their server-to-server apps in Zoom for the new authenticator, and refresh schemas if syncing data from the "meeting_registration_questions" stream.

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 7:15pm

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@ChristoGrab ChristoGrab marked this pull request as ready for review February 28, 2024 20:10
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 28, 2024 20:11
@@ -206,15 +213,16 @@ definitions:
type: SubstreamPartitionRouter
parent_stream_configs:
- stream: "#/definitions/meetings_list_tmp_stream"
parent_key: "uuid"
parent_key: "id"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Zoom docs state that either a uuid or id can be provided. However, in my tests using the "uuid" in requests simply returned a "Meeting does not exist" message. By changing to "id" I was able to successfully fetch the records in our account.

action: IGNORE
- type: DefaultErrorHandler
partition_router:
type: SubstreamPartitionRouter
parent_stream_configs:
- stream: "#/definitions/meetings_list_tmp_stream"
parent_key: "uuid"
parent_key: "id"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comment above

Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But, the changes should be applied. LGTM once fixed.

@ChristoGrab ChristoGrab requested a review from bazarnov March 12, 2024 19:06
@ChristoGrab ChristoGrab merged commit 18f6515 into master Mar 12, 2024
30 checks passed
@ChristoGrab ChristoGrab deleted the christo/zoom-fixes branch March 12, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zoom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants