-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Source amazon-sqs: Allow role based access #35483
Closed
keiththompson
wants to merge
9
commits into
airbytehq:master
from
keiththompson:keiththompson/source-amazon-sqs/allow_role_based_access
Closed
✨Source amazon-sqs: Allow role based access #35483
keiththompson
wants to merge
9
commits into
airbytehq:master
from
keiththompson:keiththompson/source-amazon-sqs/allow_role_based_access
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Connector related issues
community
connectors/source/amazon-sqs
labels
Feb 21, 2024
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
keiththompson
changed the title
Amazon SQS: Allow role based access
✨Source amazon-sqs: Allow role based access
Feb 21, 2024
keiththompson
force-pushed
the
keiththompson/source-amazon-sqs/allow_role_based_access
branch
from
February 21, 2024 14:29
fe75059
to
0a86002
Compare
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Feb 21, 2024
…allow_role_based_access
marcosmarxm
temporarily deployed
to
community-ci-auto
May 10, 2024 15:08 — with
GitHub Actions
Inactive
marcosmarxm
had a problem deploying
to
community-ci-auto
May 10, 2024 15:08 — with
GitHub Actions
Failure
marcosmarxm
had a problem deploying
to
community-ci-auto
June 5, 2024 12:37 — with
GitHub Actions
Failure
marcosmarxm
temporarily deployed
to
community-ci-auto
June 5, 2024 12:37 — with
GitHub Actions
Inactive
marcosmarxm
had a problem deploying
to
community-ci-auto
June 13, 2024 11:32 — with
GitHub Actions
Failure
marcosmarxm
temporarily deployed
to
community-ci-auto
June 13, 2024 11:32 — with
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci-auto
June 13, 2024 11:53 — with
GitHub Actions
Inactive
marcosmarxm
had a problem deploying
to
community-ci-auto
June 13, 2024 11:53 — with
GitHub Actions
Failure
marcosmarxm
temporarily deployed
to
community-ci-auto
June 13, 2024 12:21 — with
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci-auto
June 13, 2024 12:21 — with
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci-auto
June 13, 2024 15:49 — with
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci-auto
June 13, 2024 15:49 — with
GitHub Actions
Inactive
marcosmarxm
had a problem deploying
to
community-ci
June 13, 2024 15:50 — with
GitHub Actions
Failure
marcosmarxm
had a problem deploying
to
community-ci
June 13, 2024 15:50 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/source/amazon-sqs
Stale
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Amazon SQS: Allow role based access.
Currently this connector only supports using AWS Users via access and secret keys. Adding an optional session token allows this connector to run with the role of a machine user.
https://medium.com/datamindedbe/why-you-should-not-use-iam-users-d0368dd319d3
How
I added an optional session_token field to the spec and passed it through to the boto3 session.
Recommended reading order
airbyte-integrations/connectors/source-amazon-sqs/source_amazon_sqs/spec.json
airbyte-integrations/connectors/source-amazon-sqs/source_amazon_sqs/source.py
airbyte-integrations/connectors/source-amazon-sqs/integration_tests/invalid_config.json
🚨 User Impact 🚨
Because the session_token is optional, existing users will not be affected by the change.