Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Databricks: update spec+docs #42578

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Databricks: update spec+docs #42578

merged 1 commit into from
Jul 31, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jul 26, 2024 •
edited
Loading

closes https://github.com/airbytehq/airbyte-internal-issues/issues/8835; stacked on #40692

  • remove the schema evolution config option (it doesn't actually do anything)
  • first pass update/cleanup for databricks docs:
    • remove instructions for setting up a databricks cluster/warehouse (this used to be hard, databricks made it a lot easier so no need for us to explain it)
    • remove all the stuff about s3/azure/gcs staging
    • remove the stuff about parquet files
    • add explanations for dv2/refreshes stuff

@edgao edgao requested a review from a team as a code owner July 26, 2024 22:36
@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 4:29pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databricks labels Jul 26, 2024
@edgao edgao changed the base branch from master to edgao/databricks_refreshes July 26, 2024 22:37
@edgao edgao requested a review from Hesperide July 26, 2024 22:37
This was referenced Jul 26, 2024
Merged
Merged
@edgao Graphite App
Copy link
Contributor Author

edgao commented Jul 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

edgao
edgao commented Jul 26, 2024
View reviewed changes
docs/integrations/destinations/databricks.md

> **_TIP:_** There is no addition setup should be done for this type.
Follow the instructions in [Databricks documentation](https://docs.databricks.com/en/dev-tools/auth/oauth-m2m.html)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gisripa - doublechecking, is this link correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. seems correct

edgao
edgao commented Jul 26, 2024
View reviewed changes
docs/integrations/destinations/databricks.md

You could choose a data source type
![](../../.gitbook/assets/destination/databricks/databricks_open_sql_warehouse.png)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked these images, they're still accurate

@edgao edgao force-pushed the edgao/databricks_docs branch from 07de629 to 453b4a7 Compare July 26, 2024 22:42
@edgao edgao force-pushed the edgao/databricks_docs branch from 453b4a7 to 40d79af Compare July 26, 2024 23:06
gisripa
gisripa approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@gisripa gisripa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Related Tutorial has screenshots of stale connector, maybe remove that tutorial until we revamp it ?

@edgao edgao force-pushed the edgao/databricks_refreshes branch from c9a620d to 6fccc25 Compare July 31, 2024 16:19
@edgao edgao force-pushed the edgao/databricks_docs branch from 40d79af to 71cd490 Compare July 31, 2024 16:20
@edgao edgao force-pushed the edgao/databricks_docs branch from 71cd490 to 94dc913 Compare July 31, 2024 16:21
@edgao
Copy link
Contributor Author

edgao commented Jul 31, 2024

folding this PR into #40692 to release them atomically

@edgao edgao merged commit 94dc913 into edgao/databricks_refreshes Jul 31, 2024
26 of 28 checks passed
@edgao edgao deleted the edgao/databricks_docs branch July 31, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gisripa gisripa gisripa approved these changes

@Hesperide Hesperide Awaiting requested review from Hesperide

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databricks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @gisripa @octavia-squidington-iii