-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(airbyte-cdk): bump nltk and requests #48438
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been watching the nltk
alert for a while. If this can pass tests I'm 100% in favor! I vaguely recall a langchain or vector-store-related dependency linked to this - lmk if so and I'll be happy to jump in to help if needed.
There are dependency issues in the CI. Is it related to those changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for getting this going1
Working on nltk here: I think we can probably close this PR and move effort to the new one in the new repo. Over there, I'm still dealing with test failures (fwiw). |
@aldogonzalez8 and @aaronsteers did this in the new repo, closing this one. |
Pull request was closed
What
Bumps up the
nltk
andrequests
packages in airbyte-cdk, fixes a few security vulnerabilities.Fixes #45121.
Fixes https://github.com/airbytehq/airbyte-internal-issues/issues/10490