Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(airbyte-cdk): bump nltk and requests #48438

Closed
wants to merge 1 commit into from

Conversation

natikgadzhi
Copy link
Contributor

What

Bumps up the nltk and requests packages in airbyte-cdk, fixes a few security vulnerabilities.

Fixes #45121.
Fixes https://github.com/airbytehq/airbyte-internal-issues/issues/10490

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Nov 9, 2024 0:17am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Nov 9, 2024
@natikgadzhi natikgadzhi changed the title bump nltk and requests in cdk fix(airbyte-cdk): bump nltk and requests Nov 9, 2024
@natikgadzhi natikgadzhi enabled auto-merge (squash) November 9, 2024 00:18
Copy link
Contributor

@aldogonzalez8 aldogonzalez8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been watching the nltk alert for a while. If this can pass tests I'm 100% in favor! I vaguely recall a langchain or vector-store-related dependency linked to this - lmk if so and I'll be happy to jump in to help if needed.

@maxi297
Copy link
Contributor

maxi297 commented Nov 11, 2024

There are dependency issues in the CI. Is it related to those changes?

Copy link
Contributor

@wennergr wennergr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for getting this going1

@aaronsteers
Copy link
Collaborator

Working on nltk here:

I think we can probably close this PR and move effort to the new one in the new repo.

Over there, I'm still dealing with test failures (fwiw).

@natikgadzhi
Copy link
Contributor Author

@aldogonzalez8 and @aaronsteers did this in the new repo, closing this one.

auto-merge was automatically disabled November 20, 2024 18:47

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[airbyte-cd] upgrade nltk package >3.8.1
6 participants