airbyte-ci: don't require extra permissions or --is-ci flag to upload reports to GCS bucket
#48824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
aaronsteers
changed the title
--is-ci flag to upload reports to GCS bucket
natikgadzhi
approved these changes
Dec 5, 2024
aaronsteers
deleted the
aj/airbyte-ci/allow-report-uploads-with-fewer-permissions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to enable report uploads without granting a large number of new permissions, this change decouples the report upload feature from the
--is-ciflag. Originally, I tried to just enable--is-cibut then a number of other environment variables became requires, such as dockerhub username and password, which are not needed in our use cases.The fix here is simply to upload reports as long as
--ci-report-upload-bucketand the GCP creds are both set.This is tested successfully in Python CDK and ready to go!
Tested here:
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?