feat(source-the-guardian-api): Bump to latest cdk candidate version and fix custom page incremental strategy #50855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
the guardian is one of the only manifest-only sources that uses a custom pagination strategy and it is also part of our pre-merge testing connectors. We should fix this connector to ease release of other cdk changes in the future.
How
I fixed the
CustomPageIncrementstrategy implementation in accordance to the changes ot the existingPaginationStrategyinterface that will be merged in airbytehq/airbyte-python-cdk#168 .The main thing worth noting is I converted the custom component to implement the interface and NOT the existing
PageIncrementclass. This is more in line w/ how we want our custom components to adhere to interfaces so we can change underlying implementations more freelyUser Impact
n/a
Can this PR be safely reverted and rolled back?