Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-mysql: fix indentation level for rules defs #50868

Merged

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Jan 3, 2025

What

The exception classification rules for source-mysql were not being applied because they were declared at the wrong indentation level. This PR fixes this and also uses the latest CDK for good measure.

How

n/a

Review guide

n/a

User Impact

Exceptions will get handled properly now.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@postamar postamar requested a review from a team as a code owner January 3, 2025 14:58
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 7:52pm

@postamar postamar enabled auto-merge (squash) January 3, 2025 19:46
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 3, 2025
Copy link
Contributor

@yardencarmeli yardencarmeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PT and all is working! Good to go

Screenshot 2025-01-03 at 3 44 00 PM

Copy link
Contributor

@theyueli theyueli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting issue! thanks for the fix!

@postamar postamar merged commit e01e6a2 into master Jan 3, 2025
32 checks passed
@postamar postamar deleted the postamar/source-mysql-fix-exception-handling-rules-indent branch January 3, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mysql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants