Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Shopify: Add moments field to CustomerJourneySummary stream #50884

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

h0rban
Copy link

@h0rban h0rban commented Jan 3, 2025

What

Currently CustomerJourneySummary stream contains only the first and last customer visits. This PR adds an moments array with all customer visits.

Issues:

How

  • adds field to the graphql query
  • update stream schema

Review guide

  1. airbyte-integrations/connectors/source-shopify/source_shopify/shopify_graphql/bulk/query.py
  2. airbyte-integrations/connectors/source-shopify/source_shopify/schemas/customer_journey_summary.json

User Impact

additional data available useful for advanced attribution modeling

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 3, 2025

@h0rban is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 4, 2025
@h0rban h0rban temporarily deployed to community-ci-auto January 4, 2025 00:13 — with GitHub Actions Inactive
@h0rban h0rban marked this pull request as ready for review January 4, 2025 00:13
@h0rban
Copy link
Author

h0rban commented Jan 4, 2025

@bazarnov can you take a look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/shopify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants