Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination S3 Data Lake: Easier beta logistics #50968

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Destination S3 Data Lake: Easier beta logistics #50968

wants to merge 3 commits into from
+5 −10

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 7, 2025 •
edited
Loading

closes https://github.com/airbytehq/airbyte-internal-issues/issues/11275

  • rename the connector directory (destination-iceberg-v2 -> destination-s3-data-lake)
  • change the docker image name to include "BETA"
  • enable in cloud+oss
    • OSS beta users who add a custom connector need to manually set supports_refreshes = true in airbyte-db, which is annoying
    • so just enable the connector for everyone, to simplify our lives
    • but it has "beta" in the name, so hopefully won't cause confusion
    • tooling also recommends that we just make a new actor definition, so generate a new UUID

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 4:23pm

@edgao edgao marked this pull request as ready for review January 7, 2025 19:43
@edgao edgao requested a review from a team as a code owner January 7, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frifriSF59 frifriSF59 frifriSF59 approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/s3-data-lake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @frifriSF59 @octavia-squidington-iii