Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflows] set Poetry version to 1.8.5 when installing via snok/install-poetry #50970

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Jan 7, 2025

What

How

  • Explictily sets the Poetry version to v1.8.5 when installing via snok/install-poetry@1:
      - name: Install Poetry
        id: install_poetry
        uses: snok/install-poetry@v1
        with:
          version: 1.8.5

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@pnilan pnilan requested a review from a team as a code owner January 7, 2025 21:43
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 9:49pm

Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @pnilan. You might consider running live or regression tests against your branch too (using a manual GHA), but since we were already running 1.8.5 I could go either way.

@pnilan pnilan merged commit 3dd11e7 into master Jan 8, 2025
26 checks passed
@pnilan pnilan deleted the pnilan/auto-merge/set-poetry-version-1.8.0 branch January 8, 2025 18:17
@pnilan
Copy link
Contributor Author

pnilan commented Jan 8, 2025

Merged this as Poetry v2.0.0 was blocking regression tests from running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants