Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable schema evolution tests for s3 datalake #51569

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented Jan 15, 2025

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 8:55am

@octavia-squidington-iii octavia-squidington-iii added area/documentation Improvements or additions to documentation CDK Connector Development Kit labels Jan 16, 2025
@subodh1810 subodh1810 marked this pull request as ready for review January 16, 2025 10:12
@subodh1810 subodh1810 requested a review from a team as a code owner January 16, 2025 10:12
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between the base test and the copied one? at the very least, we should have a comment explaining that

(and depending on what the difference is, we maybe should add an option to the base test to switch between these behaviors, instead of copying the method wholesale into this one destination)

@subodh1810
Copy link
Contributor Author

what's the difference between the base test and the copied one? at the very least, we should have a comment explaining that

(and depending on what the difference is, we maybe should add an option to the base test to switch between these behaviors, instead of copying the method wholesale into this one destination)

There are 2 differences

  1. The base test is also changing the data type of a given column from int to string. That conversion is not allowed in Iceberg. It will throw an exception
  2. The order of elements expected. The order that base test expects and the order in which iceberg returns are different. The data is exact same, just the order is different.

@edgao
Copy link
Contributor

edgao commented Jan 16, 2025

ah, makes sense. I'll write a ticket to make the test more flexible; in the meantime, can you add that info to the javadoc comment? just so it's easy for us to find later on

@edgao
Copy link
Contributor

edgao commented Jan 16, 2025

@subodh1810 subodh1810 requested a review from edgao January 16, 2025 19:21
# Conflicts:
#	docs/integrations/destinations/s3-data-lake.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/s3-data-lake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants