-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable schema evolution tests for s3 datalake #51569
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between the base test and the copied one? at the very least, we should have a comment explaining that
(and depending on what the difference is, we maybe should add an option to the base test to switch between these behaviors, instead of copying the method wholesale into this one destination)
There are 2 differences
|
ah, makes sense. I'll write a ticket to make the test more flexible; in the meantime, can you add that info to the javadoc comment? just so it's easy for us to find later on |
# Conflicts: # docs/integrations/destinations/s3-data-lake.md
Issue: https://github.com/airbytehq/airbyte-internal-issues/issues/11225