[Iceberg] Add support for default namespace (database name) #52068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
|
/format-fix
|
octavia-squidington-iii
added
the
area/documentation
edgao
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
couple nits, otherwise 
(don't forget to regen the spec files, CI will complain)
(also cc @johnny-schmidt - if you want a testbed for https://github.com/airbytehq/airbyte-internal-issues/issues/11424's "test default namespace" thing, iceberg is adding support for that here)
.../src/main/kotlin/io/airbyte/cdk/load/command/iceberg/parquet/IcebergCatalogSpecifications.kt
Outdated
Show resolved
Hide resolved
...ta-lake/src/main/kotlin/io/airbyte/integrations/destination/s3_data_lake/TableIdGenerator.kt
Outdated
Show resolved
Hide resolved
|
/format-fix
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow our users to set a database name for the s3-data-lake destination.
This value will be used if will only be used if the stream namespace is null, meaning when the
Destination Namespacesetting for the connection is set toDestination-definedorSource-definedHow
We are checking if the stream.namespace is null and setting it to the new configuration value if that is the case
Can this PR be safely reverted and rolled back?