airbyte-ci: wire the --enable-report-auto-open option to connector tests
#52087
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alafanechere
force-pushed
the
augustin/01-22-airbyte-ci_wire_the_--enable-report-auto-open_option_to_connector_tests
branch
from
5878579 to
8432632
Compare
gosusnp
approved these changes
Jan 22, 2025
| @@ -166,6 +166,7 @@ async def test( | |||
| run_step_options=run_step_options, | |||
| targeted_platforms=[LOCAL_BUILD_PLATFORM], | |||
| secret_stores=ctx.obj["secret_stores"], | |||
| enable_report_auto_open=ctx.obj.get("enable_report_auto_open", True), | |||
There was a problem hiding this comment.
Feels like this default should be false, I am sensing this generally generates more frustration for others around me as well.
alafanechere
deleted the
augustin/01-22-airbyte-ci_wire_the_--enable-report-auto-open_option_to_connector_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several important updates to the
airbyte-ciconnectors, particularly focusing on the--enable-report-auto-openfeature and version bump. The most important changes are summarized below:Feature Enhancements:
--enable-report-auto-openoption for connector tests to ensure it functions as expected.Code Updates:
enable_report_auto_openparameter to thetestcommand inairbyte_ci/connectors/test/commands.pyto enable the auto-opening of reports by default.Versioning:
pipelinespackage from4.49.0to4.49.1inpyproject.tomlto reflect the new changes and enhancements.