Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump k8s deps to 1.26.13 #602

Merged
merged 2 commits into from
Jan 24, 2024
Merged

chore(deps): bump k8s deps to 1.26.13 #602

merged 2 commits into from
Jan 24, 2024

Conversation

byashimov
Copy link
Contributor

@byashimov byashimov commented Jan 24, 2024

To test x-kubernetes-validations we need at least 1.25.
Bumping up to the minimal maintained kube version.

@byashimov byashimov added the dependencies Pull requests that update a dependency file label Jan 24, 2024
@byashimov byashimov requested a review from a team January 24, 2024 10:01
@byashimov byashimov marked this pull request as draft January 24, 2024 10:01
@byashimov
Copy link
Contributor Author

tests

@byashimov byashimov marked this pull request as ready for review January 24, 2024 10:27
@rriski rriski self-requested a review January 24, 2024 10:48
Copy link
Contributor

@rriski rriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update

kind create cluster --image kindest/node:v1.24.0 --wait 5m

to say "kind create cluster --image kindest/node:v1.26.6 --wait 5m". The latest kind image in the v1.26 line is v1.26.6: https://hub.docker.com/r/kindest/node/tags?page=1&name=v1.26.

EDIT: missed that you already did this, LGTM

Copy link
Contributor

@rriski rriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rriski rriski merged commit 0f70021 into main Jan 24, 2024
7 checks passed
@rriski rriski deleted the byashimov-k8s-1-26 branch January 24, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants