refactor(project|billing_group): replaced client-v2 with avngen #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmyroslav
force-pushed
the
vmyroslav-project-avngen
branch
from
eee5905 to
641c5be
Compare
byashimov
requested changes
Feb 10, 2025
| Type: schema.TypeSet, | ||
| Elem: &schema.Schema{Type: schema.TypeString}, | ||
| Optional: true, | ||
| //DiffSuppressFunc: schemautil.EmptyObjectNoChangeDiffSuppressFunc, |
There was a problem hiding this comment.
Either it must be computed, or we should clearly log this change in the changelog, telling we have fixed this.
| Description: "Address lines 1 and 2. For example, street, PO box, or building.", | ||
| Type: schema.TypeSet, | ||
| Elem: &schema.Schema{Type: schema.TypeString}, | ||
| Optional: true, |
There was a problem hiding this comment.
Same here. If it is not computed, it would show the plan.
| return billinggroup.BillingCurrencyType(v.(string)) | ||
| } | ||
| return "" | ||
| }(), |
There was a problem hiding this comment.
Get always returns something. Either the real or zero value.
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr(resourceName, "name", fmt.Sprintf("test-acc-bg-%s", rName)), | ||
| resource.TestCheckResourceAttr(resourceName, "billing_emails.#", "0"), | ||
| resource.TestCheckResourceAttr(resourceName, "address_lines.#", "0"), |
| db, err := c.BillingGroup.Get(ctx, rs.Primary.ID) | ||
| var e aiven.Error | ||
| bg, err := c.BillingGroupGet(ctx, rs.Primary.ID) | ||
| var e avngen.Error | ||
| if common.IsCritical(err) && errors.As(err, &e) && e.Status != 500 { | ||
| return fmt.Errorf("error getting a billing group by id: %w", err) | ||
| } |
There was a problem hiding this comment.
This error message doesn't make sense. 500 is a clearly an error.
| if cardID == "" { | ||
| return nil, nil | ||
| } | ||
|
|
||
| card, err := client.CardsHandler.Get(ctx, cardID) | ||
| cards, err := client.UserCreditCardsList(ctx) //nolint:staticcheck |
There was a problem hiding this comment.
Why do we skip linting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change—what it does
projectandbilling_groupresources