Improved log interface performance and streaming #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schrieveslaach Please review the changes. |
schrieveslaach
requested changes
Jan 15, 2024
There was a problem hiding this comment.
Thanks for tackling this issue. I think it is a good start but in the details I want to iron out somethings:
tail_linesseems to mixed up a little- It seems to me that we don't need two implementations under the hood
Let's have a chat to figure out these things.
schrieveslaach
requested changes
Jan 24, 2024
samuchila
force-pushed
the
log-enhancement
branch
from
8c3d5c4 to
ba75ec0
Compare
schrieveslaach
requested changes
Feb 6, 2024
This commit enhances the log interface by reducing lag and improving the rendering speed. It introduces a feature to load the logs for the past day first and logs are now streamed in real-time from backend, ensuring immediate access to new logs. Additionally, a download button that downloads all logs since container was started is now made available at the top of the logs dialog.
samuchila
force-pushed
the
log-enhancement
branch
from
a1b6dda to
3302462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the log interface by reducing lag and improving the rendering speed. It introduces a feature to load the latest logs first and logs are now streamed in real-time from backend, ensuring immediate access to new logs. The infrastructure is now able to handle both streaming and one time log transfer in one function only, avoiding the use of multiple implementations. The routes ensure the output is served to the client based on content negotiation.
Fixes #25