load_pgn takes a pgn string, not a split array. Your lib is broken until that is fixed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…broken until that is fixed
ajGingrich
reviewed
Apr 12, 2020
There was a problem hiding this comment.
In which use cases is it currently failing for you? and what case is this for? I see it as four potential use cases.
- inner html -> with nodes and Event data
- no inner html -> string with event data
- inner html -> no event data
- no inner html -> no event data
I see all tests cases except for number 4 working on my current master. However, after applying your changes it breaks every case without fixing number 4.
Thanks for contributing 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.