Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cibuildwheel version; re-enable MacOS x86_64 builds #49

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

kevinsa5
Copy link
Contributor

@kevinsa5 kevinsa5 commented Jun 1, 2024

I don't know exactly what changed since November to break the MacOS builds, but I think this PR gets things working again. It makes two changes:

  • Update cibuildwheel, to fix whatever problem delocate was having.
  • It seems that macos-latest advanced to some version that only produces ARM builds, so add macos-13 to get x86_64 builds as well.

As a side note, the number of linux builds seems a bit excessive to me:

20 wheels produced in 7 minutes:
  gemlog-1.7.8-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl                                  556 kB
  gemlog-1.7.8-cp310-cp310-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl   539 kB
  gemlog-1.7.8-cp310-cp310-musllinux_1_2_i686.whl                                                          567 kB
  gemlog-1.7.8-cp310-cp310-musllinux_1_2_x86_64.whl                                                        580 kB
  gemlog-1.7.8-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl                                  594 kB
  gemlog-1.7.8-cp311-cp311-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl   574 kB
  gemlog-1.7.8-cp311-cp311-musllinux_1_2_i686.whl                                                          600 kB
  gemlog-1.7.8-cp311-cp311-musllinux_1_2_x86_64.whl                                                        617 kB
  gemlog-1.7.8-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl                                  585 kB
  gemlog-1.7.8-cp312-cp312-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl   566 kB
  gemlog-1.7.8-cp312-cp312-musllinux_1_2_i686.whl                                                          599 kB
  gemlog-1.7.8-cp312-cp312-musllinux_1_2_x86_64.whl                                                        610 kB
  gemlog-1.7.8-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl                                    564 kB
  gemlog-1.7.8-cp38-cp38-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl     548 kB
  gemlog-1.7.8-cp38-cp38-musllinux_1_2_i686.whl                                                            576 kB
  gemlog-1.7.8-cp38-cp38-musllinux_1_2_x86_64.whl                                                          592 kB
  gemlog-1.7.8-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl                                    558 kB
  gemlog-1.7.8-cp39-cp39-manylinux_2_5_i686.manylinux1_i686.manylinux_2_17_i686.manylinux2014_i686.whl     541 kB
  gemlog-1.7.8-cp39-cp39-musllinux_1_2_i686.whl                                                            569 kB
  gemlog-1.7.8-cp39-cp39-musllinux_1_2_x86_64.whl                                                          583 kB

Could consider dropping the i686 and musllinux builds. The win32 builds might be unnecessary at this point too. Anyway I'll leave that kind of configuration for potential follow-up PRs.

@kevinsa5
Copy link
Contributor Author

kevinsa5 commented Jun 1, 2024

See build job logs here: https://github.com/kevinsa5/gemlog/actions/runs/9330203028

@ajakef ajakef merged commit d2edaa9 into ajakef:main Jun 2, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants