Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding The Article On Binary Search Questions #152

Merged

Conversation

PRASHANTSWAROOP001
Copy link
Contributor

📥 Pull Request

Description

I added a new article that features pattern-wise questions on binary search. It includes links to practice questions and explanation links for better understanding of each question.

Fixes #92

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • [ ✔️] My code follows the style guidelines of this project
  • [ ✔️] I have performed a self-review of my code
  • [ ✔️] I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. hacktoberfest-accepted PRs accepted for Hacktoberfest 2024. Ensures contributions are counted towards the official Hackt... level2 GirlScript Summer of Code | Contributor's Levels labels Oct 7, 2024
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update your code based on suggestions

docs/binary-search/binary_search_questions.md Outdated Show resolved Hide resolved
docs/binary-search/binary_search_questions.md Outdated Show resolved Hide resolved
@PRASHANTSWAROOP001
Copy link
Contributor Author

I have removed the suggested lines from 14 to 31 and the bottom --- line. Thanks For The Review.

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit bd8381e into ajay-dhangar:main Oct 7, 2024
4 checks passed
@PRASHANTSWAROOP001 PRASHANTSWAROOP001 deleted the Binary-Search-Questions branch October 11, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. hacktoberfest-accepted PRs accepted for Hacktoberfest 2024. Ensures contributions are counted towards the official Hackt... level2 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] <Binary Search Pattern Wise Questions>
2 participants