Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #143 solved✨ #155

Merged
merged 9 commits into from
Oct 7, 2024
Merged

issue #143 solved✨ #155

merged 9 commits into from
Oct 7, 2024

Conversation

trahulprabhu38
Copy link
Contributor

📥 Pull Request

Description

issue #143 added combinatorics.

@ajay-dhangar please review this PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ajay-dhangar ajay-dhangar linked an issue Oct 7, 2024 that may be closed by this pull request
[Feature Request] <adding Combinatorics> #143
Closed
2 tasks
@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. hacktoberfest-accepted PRs accepted for Hacktoberfest 2024. Ensures contributions are counted towards the official Hackt... level2 GirlScript Summer of Code | Contributor's Levels labels Oct 7, 2024
ajay-dhangar
ajay-dhangar requested changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update your code based on suggestions

docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
@trahulprabhu38
Copy link
Contributor Author

resolved all problems.

@trahulprabhu38
Copy link
Contributor Author

@ajay-dhangar all the required changes done.

ajay-dhangar
ajay-dhangar requested changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update id based on suggestions to solve warning duplicate route found.

docs/combinatorics/combinatorics-theory.md Outdated Show resolved Hide resolved
docs/combinatorics/combinatorics-examples.md Outdated Show resolved Hide resolved
ajay-dhangar
ajay-dhangar approved these changes Oct 7, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit cf2fba4 into ajay-dhangar:main Oct 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-dhangar ajay-dhangar ajay-dhangar approved these changes

Assignees

@trahulprabhu38 trahulprabhu38

Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. hacktoberfest-accepted PRs accepted for Hacktoberfest 2024. Ensures contributions are counted towards the official Hackt... level2 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] <adding Combinatorics>
2 participants
@trahulprabhu38 @ajay-dhangar