-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#122 Added 5 New Algorithms under String Algorithms #187
Conversation
@ajay-dhangar Can you please review it and add GSSOC Ext and Hacktoberfest labels to it . Thanks...... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pratheekv39,
Thank you for your contributions! I have a few suggestions to improve the consistency and readability of our project:
-
File Naming Best Practices: Please rename the following files to follow a consistent, clear naming convention:
ApostolicoGiancarlo.md
→apostolico-giancarlo.md
BNDM.md
→bndm.md
Bitap.md
→bitap.md
CommentzWalter.md
→commentz-walter.md
ShiftOr.md
→shift-or.md
Using lowercase letters and hyphens between words makes file names more uniform and easier to manage across different platforms.
-
LaTeX Syntax in Markdown Files: When writing mathematical expressions in LaTeX, please ensure that you're using the correct syntax. For inline math, use single dollar signs (
$ ... $
), and for block math, use double dollar signs ($$ ... $$
). This ensures proper rendering across all markdown viewers that support LaTeX.
Example for inline math: $ O\left(\frac{n}{w}\right) $
Example for block math:
$$
O\left(\frac{n}{w}\right)
$$
Let me know if you need any assistance with these changes.
Best regards,
@ajay-dhangar
@ajay-dhangar I have made the changes that you requested . Please check once... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@pratheekv39, you need to sync our latest code. I've resolved the error, so first, sync with |
@ajay-dhangar Ok sir , I will sync the lastest code and send the updates by Monday . Been busy with some work lately:( |
⚡️ Lighthouse Report for the Deploy Preview of this PR 🚀
|
@ajay-dhangar I have resolved and updated (synced) my branch and pushed the code. Can you now approve the PR??? |
📥 Pull Request
Description
Summary of Change: Implemented 5 algorithms under the String Algorithms section:
Issue Fixed: Resolved issue [Feature Request] Addition of Apostolico–Giancarlo Algorithm,BNDM , Bitap Algorithm , Commentz-Walter Algorithm, Shift-Or Algorithm in String Algorithms #122 by adding the necessary algorithms to the string algorithms section.
Motivation: The changes enhance the algorithm coverage and provide detailed implementations for each string matching algorithm.
Context: Detailed comments were added where necessary to improve clarity and code understanding.
Dependencies: No new dependencies introduced.
Fixes #122
Type of change
Checklist:
@ajay-dhangar Please add the required labels GSSOC Ext and Hacktoberfest . Thanks....