Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#122 Added 5 New Algorithms under String Algorithms #187

Merged
merged 5 commits into from
Oct 14, 2024
Merged

#122 Added 5 New Algorithms under String Algorithms #187

merged 5 commits into from
Oct 14, 2024

Conversation

pratheekv39
Copy link
Contributor

@pratheekv39 pratheekv39 commented Oct 7, 2024

📥 Pull Request

Description

  1. Summary of Change: Implemented 5 algorithms under the String Algorithms section:

    • Apostolico–Giancarlo Algorithm
    • BNDM (Backward Nondeterministic Dawg Matching) Algorithm
    • Bitap Algorithm (Approximate String Matching)
    • Commentz-Walter Algorithm
    • Shift-Or Algorithm
  2. Issue Fixed: Resolved issue [Feature Request] Addition of Apostolico–Giancarlo Algorithm,BNDM , Bitap Algorithm , Commentz-Walter Algorithm, Shift-Or Algorithm in String Algorithms #122 by adding the necessary algorithms to the string algorithms section.

  3. Motivation: The changes enhance the algorithm coverage and provide detailed implementations for each string matching algorithm.

  4. Context: Detailed comments were added where necessary to improve clarity and code understanding.

  5. Dependencies: No new dependencies introduced.

Fixes #122

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • [ X] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my code
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes
  • [X ] Any dependent changes have been merged and published in downstream modules

@ajay-dhangar Please add the required labels GSSOC Ext and Hacktoberfest . Thanks....

@pratheekv39
Copy link
Contributor Author

@ajay-dhangar Can you please review it and add GSSOC Ext and Hacktoberfest labels to it . Thanks......

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. hacktoberfest-accepted PRs accepted for Hacktoberfest 2024. Ensures contributions are counted towards the official Hackt... level2 GirlScript Summer of Code | Contributor's Levels labels Oct 8, 2024
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pratheekv39,

Thank you for your contributions! I have a few suggestions to improve the consistency and readability of our project:

  1. File Naming Best Practices: Please rename the following files to follow a consistent, clear naming convention:

    • ApostolicoGiancarlo.mdapostolico-giancarlo.md
    • BNDM.mdbndm.md
    • Bitap.mdbitap.md
    • CommentzWalter.mdcommentz-walter.md
    • ShiftOr.mdshift-or.md

    Using lowercase letters and hyphens between words makes file names more uniform and easier to manage across different platforms.

  2. LaTeX Syntax in Markdown Files: When writing mathematical expressions in LaTeX, please ensure that you're using the correct syntax. For inline math, use single dollar signs ($ ... $), and for block math, use double dollar signs ($$ ... $$). This ensures proper rendering across all markdown viewers that support LaTeX.

Example for inline math: $ O\left(\frac{n}{w}\right) $

Example for block math:

$$
O\left(\frac{n}{w}\right)
$$

Let me know if you need any assistance with these changes.

Best regards,
@ajay-dhangar

docs/algorithms/string-algorithms/ApostolicoGiancarlo.md Outdated Show resolved Hide resolved
docs/algorithms/string-algorithms/ApostolicoGiancarlo.md Outdated Show resolved Hide resolved
docs/algorithms/string-algorithms/ApostolicoGiancarlo.md Outdated Show resolved Hide resolved
docs/algorithms/string-algorithms/BNDM.md Outdated Show resolved Hide resolved
docs/algorithms/string-algorithms/BNDM.md Outdated Show resolved Hide resolved
docs/algorithms/string-algorithms/BNDM.md Outdated Show resolved Hide resolved
docs/algorithms/string-algorithms/BNDM.md Outdated Show resolved Hide resolved
@pratheekv39
Copy link
Contributor Author

@ajay-dhangar I have made the changes that you requested . Please check once...

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar
Copy link
Owner

@ajay-dhangar I have made the changes that you requested . Please check once...

@pratheekv39, you need to sync our latest code. I've resolved the error, so first, sync with git pull origin main, push the code to your branch, and then resolve any remaining errors.

@pratheekv39
Copy link
Contributor Author

@ajay-dhangar Ok sir , I will sync the lastest code and send the updates by Monday . Been busy with some work lately:(

Copy link

⚡️ Lighthouse Report for the Deploy Preview of this PR 🚀

🔗 Site: Algo | Live Site

URL 🌐 Performance Accessibility Best Practices SEO 📊
/algo/ 🟡 67 🟢 92 🟡 79 🟡 86 📄
/algo/docs 🔴 49 🟢 93 🟡 79 🟢 100 📄
/algo/blog 🟡 72 🟡 88 🟢 100 🟡 86 📄

@pratheekv39
Copy link
Contributor Author

@ajay-dhangar I have resolved and updated (synced) my branch and pushed the code. Can you now approve the PR???

@ajay-dhangar ajay-dhangar merged commit e63a37c into ajay-dhangar:main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. hacktoberfest-accepted PRs accepted for Hacktoberfest 2024. Ensures contributions are counted towards the official Hackt... level2 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
2 participants