Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Size_of_largest_BST_in_binary_tree.md #1870

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Add Size_of_largest_BST_in_binary_tree.md #1870

merged 2 commits into from
Nov 7, 2024

Conversation

Riddhi12349
Copy link
Contributor

@Riddhi12349 Riddhi12349 commented Nov 6, 2024 •
edited
Loading

📥 Pull Request

Description

Size of largest BST in binary tree by recursively calling for left and right subtrees and return the maximum of two calls.

Fixes #1851

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible.). If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

⚡️ Lighthouse Report for the Deploy Preview of this PR 🚀

🔗 Site: Algo | Live Site

URL 🌐 Performance Accessibility Best Practices SEO 📊
/algo/ 🔴 41 🟢 96 🟡 71 🟡 86 📄
/algo/docs 🔴 46 🟢 96 🟡 75 🟢 100 📄
/algo/blog 🟡 66 🟢 92 🟢 96 🟡 86 📄

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels labels Nov 6, 2024
ajay-dhangar
ajay-dhangar requested changes Nov 6, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update your code based on suggestions

docs/DSA-Problem-Solution/Size_of_largest_BST_in_binary_tree.md Outdated Show resolved Hide resolved
@Riddhi12349
Copy link
Contributor Author

done

ajay-dhangar
ajay-dhangar approved these changes Nov 7, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit 82d7249 into ajay-dhangar:main Nov 7, 2024
5 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

🎉🎉 Thank you for your contribution! Your PR #1870 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-dhangar ajay-dhangar ajay-dhangar approved these changes

Assignees

@Riddhi12349 Riddhi12349

Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level1 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Custom]: <ADD A PROBLEM> Size of largest BST in binary tree
2 participants
@Riddhi12349 @ajay-dhangar