Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Prims Algorithm under graphs #191

Merged
merged 15 commits into from
Oct 8, 2024
Merged

Added Prims Algorithm under graphs #191

merged 15 commits into from
Oct 8, 2024

Conversation

shravya312
Copy link
Contributor

@shravya312 shravya312 commented Oct 7, 2024

📥 Pull Request

Description

Added introduction, working, step by step Explaination, Complexity analysis, application, Comparison with Kruskal's Algorithm for Prims Algorithm.

Fixes #106

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shravya312 shravya312 reopened this Oct 7, 2024
@shravya312 shravya312 changed the title Added Prims Algorithm under Added Prims Algorithm under graphs Oct 8, 2024
@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. hacktoberfest-accepted PRs accepted for Hacktoberfest 2024. Ensures contributions are counted towards the official Hackt... level2 GirlScript Summer of Code | Contributor's Levels labels Oct 8, 2024
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update your code based on suggestions and also, delete PrimsAlgorithm.md file and replace your file name Prims_Algorithm.md to prims-algorithm.md for best practices

docs/graphs/Prims_Algorithm.md Outdated Show resolved Hide resolved
docs/graphs/Prims_Algorithm.md Outdated Show resolved Hide resolved
docs/graphs/Prims_Algorithm.md Outdated Show resolved Hide resolved
docs/graphs/PrimsAlgorithm.md Outdated Show resolved Hide resolved
@shravya312
Copy link
Contributor Author

Sure I will make changes according what you have suggested and send pr again

@shravya312 shravya312 closed this Oct 8, 2024
@shravya312 shravya312 reopened this Oct 8, 2024
@shravya312
Copy link
Contributor Author

I am making changes once done I will add new commit to this pr

@shravya312
Copy link
Contributor Author

shravya312 commented Oct 8, 2024

I have made all the changes suggested Can u review it @ajay-dhangar
image
image
image
image
image
image

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update code for best practices

docs/graphs/Prims-Algorithm.md Outdated Show resolved Hide resolved
docs/graphs/Prims-Algorithm.md Outdated Show resolved Hide resolved
docs/graphs/Prims-Algorithm.md Outdated Show resolved Hide resolved
docs/graphs/Prims-Algorithm.md Outdated Show resolved Hide resolved
@shravya312
Copy link
Contributor Author

can u review the code made changes suggested @ajay-dhangar

Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar ajay-dhangar merged commit 3c2df10 into ajay-dhangar:main Oct 8, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. hacktoberfest-accepted PRs accepted for Hacktoberfest 2024. Ensures contributions are counted towards the official Hackt... level2 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add prims Algorithm under graph
2 participants