Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added radix sort and Shell sort #1948

Closed
wants to merge 4 commits into from
Closed

Added radix sort and Shell sort #1948

wants to merge 4 commits into from

Conversation

laxmikandivalasa
Copy link
Contributor

@laxmikandivalasa laxmikandivalasa commented Nov 8, 2024 •
edited
Loading

📥 Pull Request

Description

Added radix sort and Shell sort

Fixes #1909 #1908

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • [X ] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • [ X] New and existing unit tests pass locally with my changes
  • [ X] Any dependent changes have been merged and published in downstream modules

@laxmikandivalasa
Shell Sort #1909
70ee719 
 Shell Sort #1909

Idea Title
Add a new sorting algorithm

Idea Description
An optimized version of insertion sort. Shell Sort sorts elements far apart first, then progressively reduces the gap.

Potential Benefits
 Improves user experience
 Enhances learning
 Adds a new feature
 Improves code quality
 Other
@laxmikandivalasa
Radix sort #1908
3602e46 
Radix sort #1908
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible.). If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@laxmikandivalasa laxmikandivalasa changed the title Laxmikandivalasa patch 1 Added radix sort and Shell sort Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

⚡️ Lighthouse Report for the Deploy Preview of this PR 🚀

🔗 Site: Algo | Live Site

URL 🌐 Performance Accessibility Best Practices SEO 📊
/algo/ 🔴 45 🟢 96 🟡 71 🟡 86 📄
/algo/docs 🔴 43 🟢 96 🟡 75 🟢 100 📄
/algo/blog 🟡 67 🟢 92 🟢 96 🟡 86 📄

@laxmikandivalasa
Copy link
Contributor Author

@ajay-dhangar you can check the new algos added
can you assign me with level2 since i have resolved both the issues

@ajay-dhangar ajay-dhangar added gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level2 GirlScript Summer of Code | Contributor's Levels labels Nov 9, 2024
ajay-dhangar
ajay-dhangar requested changes Nov 9, 2024
View reviewed changes
Copy link
Owner

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update your code based on suggestions

docs/sortings/radix-sort.md Outdated Show resolved Hide resolved
docs/sortings/shell-sort .md Outdated Show resolved Hide resolved
@laxmikandivalasa
Copy link
Contributor Author

@ajay-dhangar you can check now!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-dhangar ajay-dhangar ajay-dhangar requested changes

Assignees

@laxmikandivalasa laxmikandivalasa

Labels
gssoc-ext Contributions made as part of GirlScript Summer of Code Extended Edition. level2 GirlScript Summer of Code | Contributor's Levels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Idea]: Shell Sort
2 participants
@laxmikandivalasa @ajay-dhangar