Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 4.14.0 (beta1) #179

Merged
merged 14 commits into from
Feb 28, 2022
Merged

Support for 4.14.0 (beta1) #179

merged 14 commits into from
Feb 28, 2022

Conversation

xclerc
Copy link
Contributor

@xclerc xclerc commented Feb 5, 2022

This pull request simply adds support for OCaml 4.14.0.
(Since it is only the first alpha, it is not clear whether it
should be considered for merge right now.)

@xclerc
Copy link
Contributor Author

xclerc commented Feb 5, 2022

Note: the CI fails because the following line:

opam switch create . --no-install --packages 4.14.0~alpha1

results in:

opam: option `--packages': invalid element in list (`4.14.0~alpha1'): Invalid character in package name "4.14.0~alpha1"

It looks like the GitHub Actions for OCaml do not support
versions with a ~; I will try and investigate.

@xclerc
Copy link
Contributor Author

xclerc commented Feb 5, 2022

It turns out it is a known problem; thanks to @kit-ty-kate for
pointing to this issue.
Happy to try and adapt the CI file if you think the workaround
is acceptable, but you may prefer to wait for 4.14 to be actually
published.

@akabe
Copy link
Owner

akabe commented Feb 24, 2022

@xclerc Thank you for your patch and sorry for late reply.
It seems that your changes have no problems.

I will merge this PR after CI works.
I don't know release of either of 4.14 or setup-ocaml is fast.

@xclerc xclerc changed the title Support for 4.14.0 (alpha1) Support for 4.14.0 (beta1) Feb 27, 2022
@xclerc
Copy link
Contributor Author

xclerc commented Feb 27, 2022

No worries! I have bumped the version to "beta1",
and tweaked the CI file in an attempt to make the
beta version installable.

@xclerc
Copy link
Contributor Author

xclerc commented Feb 27, 2022

Sorry for the back and forth, it took me some
time to make the CI green. In particular, I did
not notice at first that some errors were not
due to this pull request but to a deprecation
in Uuidm (See commit f066c71). Please let
know if you prefer to have this change in
another pull request.

@akabe
Copy link
Owner

akabe commented Feb 28, 2022

Thanks for many trials and replacement of Uuidm.create.
I think your patch is good.
However I would like to know the probability that ocaml parsetree will change from 4.14.0~alpha1 to the official release of 4.14.0.
If I don't to worry about that, I will merge this PR and release to opam.

@kit-ty-kate
Copy link
Contributor

However I would like to know the probability that ocaml parsetree will change from 4.14.0~alpha1 to the official release of 4.14.0.

The latest version is not beta1 and the parsetree will not change.

@akabe
Copy link
Owner

akabe commented Feb 28, 2022

Thank you!

@akabe akabe merged commit f369b41 into akabe:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants