Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user): add user api keys schema + api #787

Merged
merged 36 commits into from
Feb 12, 2025
Merged

feat(user): add user api keys schema + api #787

merged 36 commits into from
Feb 12, 2025

Conversation

baktun14
Copy link
Contributor

@baktun14 baktun14 commented Feb 5, 2025

@baktun14 baktun14 requested a review from a team as a code owner February 5, 2025 02:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 92.61084% with 15 lines in your changes missing coverage. Please review.

Project coverage is 22.39%. Comparing base (3180198) to head (8e8e164).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
apps/api/src/auth/services/auth.interceptor.ts 63.63% 8 Missing ⚠️
.../api/src/user/repositories/user/user.repository.ts 0.00% 3 Missing and 1 partial ⚠️
.../components/deployments/DeploymentDetailTopBar.tsx 0.00% 2 Missing ⚠️
...i/src/auth/model-schemas/api-key/api-key.schema.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #787       +/-   ##
===========================================
+ Coverage   11.30%   22.39%   +11.08%     
===========================================
  Files         438      640      +202     
  Lines       11576    16060     +4484     
  Branches     2449     3092      +643     
===========================================
+ Hits         1309     3596     +2287     
- Misses      10093    12115     +2022     
- Partials      174      349      +175     
Flag Coverage Δ
api 53.58% <93.53%> (?)
deploy-web 8.72% <0.00%> (ø)
provider-proxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ygrishajev ygrishajev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is auth module present in the api already. Api keys falls down under it's domain. user domain can be related but it's generally a different one that can have a bunch of own specifics to separate from.

@baktun14 baktun14 requested a review from ygrishajev February 12, 2025 18:07
@baktun14 baktun14 merged commit 2eac7e9 into main Feb 12, 2025
6 checks passed
@baktun14 baktun14 deleted the features/api-keys branch February 12, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants