Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(billing): unify deployment modals #804

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jzsfkzm
Copy link
Contributor

@jzsfkzm jzsfkzm commented Feb 6, 2025

refs #628

@jzsfkzm jzsfkzm requested a review from a team as a code owner February 6, 2025 11:44
@baktun14
Copy link
Contributor

baktun14 commented Feb 6, 2025

#628 (comment)

@baktun14
Copy link
Contributor

baktun14 commented Feb 6, 2025

Do we need to remove

const createDeploymentConfirm = async (services: ServiceType[]) => {
?

@jzsfkzm jzsfkzm force-pushed the deposit-modal-for-managed branch from bb199db to 0721038 Compare February 9, 2025 23:03
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 8.69%. Comparing base (64202f7) to head (0721038).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
.../components/deployments/DeploymentDepositModal.tsx 0.00% 16 Missing and 1 partial ⚠️
...web/src/components/new-deployment/ManifestEdit.tsx 0.00% 5 Missing ⚠️
...pps/deploy-web/src/components/sdl/RentGpusForm.tsx 0.00% 4 Missing ⚠️
...ploy-web/src/hooks/useManagedDeploymentConfirm.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (64202f7) and HEAD (0721038). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (64202f7) HEAD (0721038)
provider-proxy 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #804       +/-   ##
==========================================
- Coverage   80.87%   8.69%   -72.18%     
==========================================
  Files          12     426      +414     
  Lines         413   11158    +10745     
  Branches       75    2367     +2292     
==========================================
+ Hits          334     970      +636     
- Misses         79    9634     +9555     
- Partials        0     554      +554     
Flag Coverage Δ
deploy-web 8.69% <0.00%> (?)
provider-proxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants